On 2019/07/31 12:52, Stuart Henderson wrote:
> >  
> >  DISTNAME=          geoclue-0.12.99
> > -REVISION=          7
> > +REVISION=          8
> >  SHARED_LIBS +=  geoclue              1.1      # .0.0
> >  CATEGORIES=                geo devel
> 
> No objection to your diff, but TBH I would just use --disable-gpsd for
> this, this is the ancient version of geoclue that is only used by a few
> outdated Qt things and probably not anything that actually wants real
> location. The patch to the configure script can also be dropped then.

Oh BTW, if you do use your diff, please include a link to the origin of
the patch, or https://bugs.freedesktop.org/show_bug.cgi?id=40996 where it's
mentioned (alongside a "Parsing NMEA strings is definitely the wrong
way. IMHO the whole gpsd provider needs to be rewritten from scratch"
comment :)


> $ grep -w geo/geoclue INDEX | cut -d'|' -f1
> geoclue-0.12.99p8
> qtbase-5.9.7p6
> qtbase-examples-5.9.7
> qt5-global-5.9.7p0
> qt5-mysql-5.9.7p0
> qt5-postgresql-5.9.7p0
> qt5-sqlite2-5.9.7p0
> qt5-tds-5.9.7p0
> qtwebkit-5.9.0p8
> 
> (And geoclue2 doesn't enable gpsd support).
> 
> > +TEST_DEPENDS=              misc/gpsd,-main \
> 
> This would be better with a version spec e.g.
> 
> TEST_DEPENDS= ${FULLPKGNAME-main}:${FULLPKGPATH-main}
> 
> > Index: pkg/PLIST-php
> > ===================================================================
> > RCS file: /cvs/ports/misc/gpsd/pkg/PLIST-php,v
> > retrieving revision 1.1
> > diff -u -p -u -p -r1.1 PLIST-php
> > --- pkg/PLIST-php   8 Feb 2007 23:03:38 -0000       1.1
> > +++ pkg/PLIST-php   25 Jul 2019 07:56:08 -0000
> > @@ -1,3 +1,4 @@
> >  @comment $OpenBSD: PLIST-php,v 1.1 2007/02/08 23:03:38 ckuethe Exp $
> > +@cwd /var/www
> >  gpsd/
> >  gpsd/gpsd.php
> 
> This shouldn't be needed with PREFIX-php?
> 

Reply via email to