On 7/28/19 4:11 PM, Klemens Nanni wrote:
On Fri, Jul 26, 2019 at 10:00:21PM -0400, Brian Callahan wrote:Attached is a new port, mail/dma. dma is the DragonFly Mail Agent, the tiny little mailer program from DragonFly BSD.Looks fine to me, see comments below.pkg/README: $OpenBSD$ ... Below is an example /etc/mailer.conf that will work with dma.How about providing this as an example config under the usual path? Also, there's ${WRKSRC}/dma.conf that might be worth shipping.
Added mailer.conf as an example config.I thought I had included dma.conf but I guess not. It's there now. Both dma.conf and auth.conf are @sample'd into the correct place (${SYSCONFDIR}/dma/) but I chose not to @sample mailer.conf, as systems come with a /etc/mailer.conf by default.
Regarding your do-install target: the comment does not really help, it
merely makes me look why you're doing this instead of explaining it in
the first place.
That said, have you seen ${WRKSRC}/bsd/dma/Makefile?
I did. This port is my own fork of dma because of a bunch of FreeBSD/DFly compat that had to be included and I would have to modify either Makefile no matter which way I went so I chose to modify ${WRKSRC}/Makefile to make my life easier. So I simply did the right thing for an install target in ${WRKSRC}/Makefile too now so the do-install target goes away.
Additionally, there are some fixes in the updated attached tarball. OK? ~Brian
dma.tgz
Description: application/compressed-tar
