On Thu, 25 Jul 2019 14:38:16 -0700 Peter Ezetta wrote: > Hello Charlene, > > I have changed the license to Apache 2.0 in the comment, and added > PKG_ARCH = *. Is it still okay to have PERMIT_PACKAGE = Yes with the > Apache license?
Yes. The porting guide mentions that as long as we can put the package on the mirrors and mirror the distfiles as well, it should be set to Yes. The Apache 2.0 license allows that. > I will definitely take a look at portgen for my future Perl ports. You should review your two other submissions against it - there are similar errors as i've read them ;) > Thanks for the review, updated port attached. > > Regards, > > Peter OK cwen@ if someone is willing to import. > On Thu, Jul 25, 2019 at 2:23 PM Charlene Wendling > <juliana...@posteo.jp> wrote: > > > Hi! > > > > On Tue, 23 Jul 2019 16:35:15 -0700 > > Peter Ezetta wrote: > > > > > Hi ports@, > > > > > > The attached port provides Exception::Class::TryCatch, which is a > > > requirement for devel/p5-CLI-Framework, which I will be submitting > > > shortly. The port builds cleanly and passes all tests on my amd64 > > > running today's -current. > > > > > > I am fairly new to porting, so any feedback would be greatly > > > appreciated. > > > > > > Comments? Ok? > > > > > > Peter > > > > Your port is working, but there are issues: > > > > - License is "Apache 2.0" actually [0] > > - This module is architecture independent, so it needs: > > > > PKG_ARCH = * > > > > With these changes, it would be good. > > > > I recommend you to use portgen(1) to generate new Perl 5 ports. > > You'll need some extra packages, this is described in the manpage. > > The script itself can be found > > at /usr/ports/infrastructure/bin/portgen. It does *at least* 80% of > > the job for you ;) > > > > Charlène. > > > > > > [0] > > https://metacpan.org/pod/Exception::Class::TryCatch#COPYRIGHT-AND-LICENSE > >
