On Sun, Jul 21, 2019 at 01:36:15PM +0200, Caspar Schutijser wrote: > Hi, > > On Fri, May 31, 2019 at 08:10:03PM +0200, Landry Breuil wrote: > > Bah, spoke too fast, we have pyqt 5.9 because qt 5.9. Still py-sip is > > lagging behind a bit :) > > landry@ recently updated the py-sip port (thank you!). So with that > out of the way, I hope we can look at updating editors/{,py-}qscintilla > again. In the meantime, a new version was released so I updated the > diff. I performed the same amount of testing as last time, to repeat: > > I build-tested the following ports that depend on {,py-}qscintilla: > cad/openscad > databases/sqliteman > geo/qgis > x11/kde4/p5-qt > x11/kde4/qyoto > x11/kde4/ruby-qt > x11/kde4/smokeqt > > In the case of the ports below, I did not only build-test them, I also > performed some run-time testing: > databases/sqlitebrowser > devel/tortoisehg > math/octave (very light testing) > > Feedback is appreciated.
On the diff itself, dependency between py- and the lib should be enforced, otherwise you get this: Error: QScintilla 2.10.1 is being used but the Python bindings 2.11.2 are being built. Please use matching versions. LIB_DEPENDS = editors/qscintilla,qt5>=2.11.2 (and its equivalent for the default FLAVOR, and maybe even = and not >= ) in py-qscintilla Makefile does the trick. Landry