On 2019/07/14 18:19, Andrew Hewus Fresh wrote:
> On Sun, Jul 14, 2019 at 07:34:57PM -0400, Kurt Mosiejczuk wrote:
> > Right now the portgen(1) PyPI module populates DESCR from the "summary"
> > section of the json it fetches. The summary is the same thing it uses
> > for COMMENT and it's really too sparse for DESCR. This simple diff
> > switches it to use the description field. That is the field displayed
> > on the project page for pypi.org. It will probably often need trimming down
> > but I think that's a better starting point than the summary.
>
> This switches COMMENT to use the long "description", I think you meant
> to change the `set_decr` line that is 6 lines down from that.
>
> In any case, I did look at using $di->{info}{description} for pkg/DESCR
> at some point in the past, but it was a big change and pretty much would
> *require* editing DESCR. I guess that's true of the "summary" as well,
> so if you prefer this, OK afresh1@
OK with me too, I think this is a better starting point to edit from.
>
> >
> > cc afresh1
> >
> > --Kurt
> >
> > Index: PyPI.pm
> > ===================================================================
> > RCS file: /cvs/ports/infrastructure/lib/OpenBSD/PortGen/Port/PyPI.pm,v
> > retrieving revision 1.16
> > diff -u -p -r1.16 PyPI.pm
> > --- PyPI.pm 16 May 2019 16:01:10 -0000 1.16
> > +++ PyPI.pm 14 Jul 2019 23:21:37 -0000
> > @@ -81,7 +86,7 @@ sub fill_in_makefile
> >
> > $self->set_other( 'MODPY_PI', 'Yes' );
> > $self->set_other( 'MODPY_SETUPTOOLS', 'Yes' );
> > - $self->set_comment( $di->{info}{summary} );
> > + $self->set_comment( $di->{info}{description} );
> > $self->set_other( 'MODPY_EGG_VERSION', $version );
> > $self->set_distname($distname);
> > $self->set_modules('lang/python');
> >
>
> --
> andrew - http://afresh1.com
>
> People who invent random theories which only defend the vendor must have
> been beaten as children. Beaten with sticks.
> At least, that's my theory.
> -- Theo De Raadt
>
