Le 01-07-2019 14:22, Jeremie Courreges-Anglas a écrit :
Hi,the Makefile of py-llvmlite reads as follows: --8<-- WANTLIB += ${COMPILER_LIBCXX} m COMPILER = base-clang ports-gcc base-gcc MODULES = lang/python FLAVORS = python3 FLAVOR ?= BUILD_DEPENDS = devel/llvm>=7.0.1 -->8-- The COMPILER line was mechanically added because of ${COMPILER_LIBCXX}. devel/llvm in BUILD_DEPENDS is not needed: by default base-clang, /usr/bin/llvm-config and /usr/lib/libLLVM.so.1.0 are used. The build system also explicitely passes -stdlib=libc++; libc++ is (officially) available only on CLANG_ARCHS, and using libestdc++ with ports-clang isn't tested AFAIK. This lead me to the diff below: - reorder GH_*/PKGNAME and tweak spacing (reads better to me) - move to PERMIT_PACKAGE - properly register libLLVM in WANTLIB - require base-clang. This officially restricts py-llvmlite and py-miasm to CLANG_ARCHS. - drop BUILD_DEPENDS - explicitely use /usr/bin/llvm-config - move do-test after BUILD/RUN_DEPENDS tweaks All tests still pass (3 skipped). ok?
Hi, sounds good to me, thanks. Cheers, Remi.
