On Mon, Jul 01 2019, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote:
> Hi Rafael,
>
> On Mon, Mar 11 2019, Rafael Sadowski <raf...@sizeofvoid.org> wrote:
>> Update opencv to 3.4.2.
>>
>> Tested with upcoming nomacs update and digikam.
>>
>> Face detection and recognition works quite well with this version and
>> upcoming digikam5.
>
> Was there a reason for this change
>
>> -MODULES =           devel/cmake \
>> +MODULES =           lang/clang \
>> +                    devel/cmake \
>>                      lang/python
>
> when
>
>   COMPILER =          base-clang ports-gcc base-gcc
>
> ?
>
> I see that there's some code in opencv  that #includes <llvm/...>:
>
>   ./3rdparty/ittnotify/include/llvm_jit_event_listener.hpp
>
> but it doesn't appear to be built nor shipped.
>
> If there's indeed no reason to use the clang module then I'd suggest the
> patch below (build ongoing).  No bump needed since only BUILD_DEPENDS
> change.

FLAVOR='no_docs no_java' packages fine.  Unless you know about a hidden
dep... ok?


Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/opencv/Makefile,v
retrieving revision 1.49
diff -u -p -r1.49 Makefile
--- Makefile    11 Jun 2019 00:38:35 -0000      1.49
+++ Makefile    1 Jul 2019 10:33:04 -0000
@@ -41,7 +41,7 @@ WANTLIB-java += opencv_videoio
 
 WANTLIB-docs =
 
-COMPILER =             base-clang ports-gcc base-gcc
+COMPILER =             base-clang ports-gcc
 
 MASTER_SITES =         ${MASTER_SITE_SOURCEFORGE:=opencvlibrary/}
 EXTRACT_SUFX =         .zip
@@ -55,8 +55,7 @@ PERMIT_PACKAGE_CDROM =        Yes
 
 .include <bsd.port.arch.mk>
 
-MODULES =              lang/clang \
-                       devel/cmake \
+MODULES =              devel/cmake \
                        lang/python
 
 BUILD_DEPENDS =                devel/doxygen \


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to