On Sat, Jun 22, 2019 at 12:10:05PM +0200, Klemens Nanni wrote:
> Latest release is 2.1 from 2017, you picked latest HEAD from 26.04.2019,
> is there any particular reason or did you just go with the newest?
> Either way, this information would be nice to have somewhere as comment.
the reason was in the initial message :)
- the port version is "2.1pl0" : the official 2.1 (from Jul 26, 2017)
doesn't build against LLVM 7. There are commits in master branch to
support it, so I targeted the latest commit in master branch (Mar 26,
2019).
It is still versioned as "2.1" in code source, so the port has
"2.1 patchlevel 0", and we could increment the patchlevel if we
target a
new commit still in 2.1, or switch to 2.2 when released.
> SEPARATE_BUILD is already "Yes" due to cmake.
>
> Use of `arch -ks` or so in README would make the provided example work
> on all LLVM_ARCHS, not just amd64.
it is an example... you could use it on something else than the kernel.
> Can you add comments to the patches? I think it helps to see what is
> patched (and why) during `make patch' output - makes me check less for
> still valid patches on port updates.
>
> With PORTS_PRIVSEP=Yes and even FIX_EXTRACT_PERMISSIONS=Yes I get
>
> $ make extract
> ===> Checking files for woboq_codebrowser-2.1pl0
> `/tmp/distfiles/woboq_codebrowser-2.1pl0-d1a92c6c.tar.gz' is up to date.
> >> (SHA256) woboq_codebrowser-2.1pl0-d1a92c6c.tar.gz: OK
> ===> woboq_codebrowser-2.1pl0 depends on: cmake-* -> cmake-3.10.2p2v0
> ===> woboq_codebrowser-2.1pl0 depends on: ninja->=1.5.1 -> ninja-1.8.2p1
> ===> woboq_codebrowser-2.1pl0 depends on: llvm->=7.0.1 -> llvm-7.0.1p13
> ===> Verifying specs: c++ c++abi pthread c m
> ===> found c++.3.0 c++abi.1.0 pthread.26.1 c.95.1 m.10.1
> ===> Extracting for woboq_codebrowser-2.1pl0
> make: getcwd: Permission denied
> *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2565
> '/usr/ports/pobj/woboq_codebrowser-2.1pl0/.extract_done')
> *** Error 1 in /usr/ports/devel/woboq_codebrowser
> (/usr/ports/infrastructure/mk/bsd.port.mk:2481 'extract')
>
> After `chmod a+rX devel/woboq_codebrowser' (as suggested by you/semarie
> off-list), I get
I suggested chmod with *-R*. The tarball (in my mail) has wrong mode for
PORTS_PRIVSEP: _pbuild can't read the ports tree.
FIX_EXTRACT_PERMISSIONS is for fixing the upstream tarball. here it is fine.
> $ make extract
> ===> Checking files for woboq_codebrowser-2.1pl0
> `/tmp/distfiles/woboq_codebrowser-2.1pl0-d1a92c6c.tar.gz' is up to date.
> >> (SHA256) woboq_codebrowser-2.1pl0-d1a92c6c.tar.gz: OK
> ===> Extracting for woboq_codebrowser-2.1pl0
> make: don't know how to make do-extract
> Stop in .
> *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2565
> '/usr/ports/pobj/woboq_codebrowser-2.1pl0/.extract_done')
> *** Error 1 in /usr/ports/mystuff/devel/woboq_codebrowser
> (/usr/ports/infrastructure/mk/bsd.port.mk:2481 'extract')
>
--
Sebastien Marie
