On Tue, Jun 11, 2019 at 04:16:04PM +1000, Jonathan Gray wrote:
> I don't see why you are removing libcurses and libz from wantlib
Because even after Stuart's reply and my revised diff, I rushed things
without looking around... `make port-lib-depends-check` lists those libs
as extra - I should check why it does that instead of blindly removing
them, sorry.
> Is there a push to move everything to python3 now?
No "official" or (internally) planned one, but moving steadily moving
ports off the old version which is officially deprecated in 2020 has
gone well so far - we'll have to ditch Python 2 eventually and IWYU
upstream has been supporting Python 3 since years, so that's that.
> Changing MODPY_ADJ_FILES to a glob seems a bit pointless.
I did this to avoid listing them all; with tests enabled the list grows
and instead of amending them on future versions, globbing does the job
in a generic way.
> Should do-test explictly use ${MODPY_BIN} ?
Redundant as the shebang has been adjusted at this point; if not, that
would be a bug in our framework or weird/bad porters usage.
That said, MODPY_BIN is more explicit and works regardless of the file's
execute bit. I have no strong opinion, your call.
