On 2019/06/08 09:26, Ben Davies wrote:
> I'm planning on upgrading MoarVM, nqp, and rakudo at some point in the 
> next couple weeks, since there have been many improvements on OpenBSD 
> compatibility on them lately, but MoarVM requires libuv v1.29.1 rather 
> than v1.24.1 like what's available now. Would anyone be interested in 
> helping test the upgrade out? I tested on amd64 and have been running a 
> bot using it, FWIW.
> 
> Here's the diff:
> 
> ? diff

This diff doesn't apply, it probably got mangled by MS mail
infrastructure somewhere. This list does accept attachments which may
survive better.

> ? patches/patch-test_test-getaddrinfo_c

missing 'cvs add' for this file.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/libuv/Makefile,v
> retrieving revision 1.10
> diff -u -p -r1.10 Makefile
> --- Makefile    20 May 2019 04:47:01 -0000    1.10
> +++ Makefile    8 Jun 2019 09:24:18 -0000
> @@ -4,10 +4,10 @@
> 
>   COMMENT =    multi-platform library for asynchronous I/O
> 
> -VER =        1.24.1
> -DISTNAME =    libuv-v${VER}
> -PKGNAME =    libuv-${VER}
> -CATEGORIES =    devel
> +VER        = 1.29.1
> +DISTNAME   = libuv-v${VER}
> +PKGNAME    = libuv-${VER}
> +CATEGORIES = devel
> 
>   SHARED_LIBS =    uv 2.0    # 1.0

new functions were added (none were removed, and I don't see any ABI
change in existing functions) so this needs a minor version bump
(2.0 -> 2.1). (I just did a minimal test to see this i.e. changing
the version in the Makefile by hand, I don't feel like hand
applying the other patches)

> @@ -20,7 +20,12 @@ PERMIT_PACKAGE_CDROM = Yes
> 
>   WANTLIB += pthread
> 
> -BUILD_DEPENDS =    textproc/py-sphinx
> +BUILD_DEPENDS = devel/autoconf/2.69 \
> +                devel/automake/1.14 \
> +                devel/gmake \
> +                devel/libtool \
> +                devel/metaauto \
> +                textproc/py-sphinx

this was already ok; these are added automatically by CONFIGURE_STYLE
and USE_GMAKE. (see "make show=BUILD_DEPENDS")

for libuv updates it's critical to test that cmake still works with the
update; there are only a few other ports that depend on it directly so
it would be easy enough to at least test that builds still work, and
basic runtime tests for at least some -

devel/cmake
devel/py-uv
devel/py-uv,python3
devel/radare2/main
editors/neovim
lang/moarvm
www/h2o

Reply via email to