> > > Index: arch-defines.mk
> > > ===================================================================
> > > RCS file: /cvs/ports/infrastructure/mk/arch-defines.mk,v
> > > retrieving revision 1.64
> > > diff -u -p -r1.64 arch-defines.mk
> > > --- arch-defines.mk       11 May 2019 12:05:46 -0000      1.64
> > > +++ arch-defines.mk       27 May 2019 18:52:04 -0000
> > > @@ -36,7 +36,7 @@ LLD_ARCHS = aarch64 amd64 arm i386
> > >  # as well as available for PROPERTIES checks.
> > >  LLVM_ARCHS = aarch64 amd64 arm i386 mips64 mips64el powerpc sparc64
> > >  # arches where gcc4.9 exists.  To be used again for modules
> 
> I agree with postponing renaming the variable to a separate step.
> But to avoid confusion until then, I would also change the comment here,
> e.g. something like
> 
> "arches where ports gcc exists (XXX any version, not just 4.9)"

In this case I suggest the following diff, so people can slack on the
rename dance, except for bsd.port.mk(5):


Index: arch-defines.mk
===================================================================
RCS file: /cvs/ports/infrastructure/mk/arch-defines.mk,v
retrieving revision 1.64
diff -u -p -u -p -r1.64 arch-defines.mk
--- arch-defines.mk     11 May 2019 12:05:46 -0000      1.64
+++ arch-defines.mk     28 May 2019 15:16:33 -0000
@@ -35,10 +35,10 @@ LLD_ARCHS = aarch64 amd64 arm i386
 # arches where ports devel/llvm builds - populates llvm ONLY_FOR_ARCHS
 # as well as available for PROPERTIES checks.
 LLVM_ARCHS = aarch64 amd64 arm i386 mips64 mips64el powerpc sparc64
-# arches where gcc4.9 exists.  To be used again for modules
-GCC49_ARCHS =alpha amd64 arm hppa i386 mips64 mips64el powerpc sparc64
+# arches where ports-gcc >4.9 exists.  To be used again for modules
+GCC49_ARCHS = aarch64 alpha amd64 arm hppa i386 mips64 mips64el powerpc sparc64
 
-# arches where there is a C++11 compiler, either clang in base or gcc4
+# arches where there is a C++11 compiler, either clang in base or ports-gcc
 CXX11_ARCHS = ${CLANG_ARCHS} ${GCC49_ARCHS}
 
 .for PROP in ALL APM BE LE LP64 CLANG GCC4 GCC3 GCC49 MONO LLVM \

Reply via email to