On Mon, May 27, 2019 at 11:25:28AM -0700, Thomas Frohwein wrote: > My main concern here is that I think this should have a MAINTAINER. > jsg@, you didn't add yourself, so I interpret this as that you would > prefer these ports be maintained by someone else? I am offering to be > MAINTAINER, but if someone with more experience with the lower-level > aspects of GPUs/Vulkan is ready to step up, I would gladly leave it to > that developer. There are regular updates to these ports on GitHub, and > IMO the future maintainer should work on upstreaming the patches.
Great, happy for you to take MAINTAINER on these. >=20 > Otherwise it works fine here - tested also with vulkaninfo, vkcube, and > vkQuake (I have a port for the latter ready for once > graphics/vulkan-loader is in the tree). Graphics hardware is a Vega 64 > running amdgpu. >=20 > I've attached an updated tarball, updated to latest releases (sdk > releases in the case of the vulkan-* ports), me as proposed maintainer, > the adjusted license comments for glslang and spirv-headers, and some > style nits applied (space before '=3D', order of Makefile entries same as > Makefile.template). >=20 > Some comments with context below. >=20 > Comments? ok? glslang missing email address in MAINTAINER spirv-tools should use GH_TAGNAME v2019.3 instead of specifying a commit that matches the tag. vulkan-loader patch-loader_CMakeLists_txt can drop the second removal of -ldl in apple specific codepath regarding Rafael Sadowski's earlier comments https://marc.info/?l=3Dopenbsd-ports&m=3D155428789125913&w=3D2 I would add the NO_TEST parts, ignore the CONFIGURE_ARGS changes and consider adjusting the installed python files which have '#!/usr/bin/python3'. With your ports and a similiar update I tried yesterday I can't get vulkan-validation-layers-1.1.106 to build with vulkan-validation-layers-1.1.101 installed, with the earlier version removed it builds: =3D=3D=3D> Looking for vulkan-validation-layers-1.1.106.0.tgz in $PKG_PATH= - Can't find Yes Can't find vulkan-validation-layers-1.1.106.0.tgz Couldn't install vulkan-validation-layers-1.1.106.0 not found *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2010 '/usr/ports= /packages/amd64/cache/vulkan-validation-layers-1.1.106.0.tgz': @i...) =3D=3D=3D> Checking files for vulkan-validation-layers-1.1.106.0 `/usr/ports/distfiles/Vulkan-ValidationLayers-sdk-1.1.106.0.tar.gz' is up t= o date. >> (SHA256) Vulkan-ValidationLayers-sdk-1.1.106.0.tar.gz: OK =3D=3D=3D> vulkan-validation-layers-1.1.106.0 depends on: glslang-* -> glsl= ang-7.11.3214 =3D=3D=3D> vulkan-validation-layers-1.1.106.0 depends on: vulkan-headers-* = -> vulkan-headers-1.1.106.0 =3D=3D=3D> vulkan-validation-layers-1.1.106.0 depends on: spirv-tools-* -> = spirv-tools-2019.3 =3D=3D=3D> vulkan-validation-layers-1.1.106.0 depends on: cmake-* -> cmake-= 3.10.2p2v0 =3D=3D=3D> vulkan-validation-layers-1.1.106.0 depends on: ninja->=3D1.5.1 -= > ninja-1.8.2p1 =3D=3D=3D> vulkan-validation-layers-1.1.106.0 depends on: python->=3D3.7,<3= =2E8 -> python-3.7.3p1 =3D=3D=3D> Verifying specs: c++ c++abi pthread m =3D=3D=3D> found c++.2.2 c++abi.0.1 pthread.26.1 m.10.1 =3D=3D=3D> Extracting for vulkan-validation-layers-1.1.106.0 =3D=3D=3D> Patching for vulkan-validation-layers-1.1.106.0 =3D=3D=3D> Applying OpenBSD patch patch-CMakeLists_txt Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |$OpenBSD$ | |Index: CMakeLists.txt |--- CMakeLists.txt.orig |+++ CMakeLists.txt -------------------------- Patching file CMakeLists.txt using Plan A... Hunk #1 succeeded at 88. done =3D=3D=3D> Applying OpenBSD patch patch-layers_vk_loader_platform_h Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |$OpenBSD$ | |Index: layers/vk_loader_platform.h |--- layers/vk_loader_platform.h.orig |+++ layers/vk_loader_platform.h -------------------------- Patching file layers/vk_loader_platform.h using Plan A... Hunk #1 succeeded at 31. done =3D=3D=3D> Applying OpenBSD patch patch-layers_vk_mem_alloc_h Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |$OpenBSD$ | |Index: layers/vk_mem_alloc.h |--- layers/vk_mem_alloc.h.orig |+++ layers/vk_mem_alloc.h -------------------------- Patching file layers/vk_mem_alloc.h using Plan A... Hunk #1 succeeded at 3176. done =3D=3D=3D> Compiler link: clang -> /usr/bin/clang =3D=3D=3D> Compiler link: clang++ -> /usr/bin/clang++ =3D=3D=3D> Compiler link: cc -> /usr/bin/cc =3D=3D=3D> Compiler link: c++ -> /usr/bin/c++ =3D=3D=3D> Generating configure for vulkan-validation-layers-1.1.106.0 =3D=3D=3D> Configuring for vulkan-validation-layers-1.1.106.0 -- The C compiler identification is Clang 7.0.1 -- The CXX compiler identification is Clang 7.0.1 -- Check for working C compiler: /usr/ports/pobj/vulkan-validation-layers-1= =2E1.106.0/bin/cc -- Check for working C compiler: /usr/ports/pobj/vulkan-validation-layers-1= =2E1.106.0/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /usr/ports/pobj/vulkan-validation-layers= -1.1.106.0/bin/c++ -- Check for working CXX compiler: /usr/ports/pobj/vulkan-validation-layers= -1.1.106.0/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Found PythonInterp: /usr/local/bin/python3 (found suitable version "3.7.= 3", minimum required is "3")=20 -- Found VulkanHeaders: /usr/local/include =20 -- Found VulkanRegistry: /usr/local/share/vulkan/registry =20 -- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.1")=20 -- Found xcb: /usr/X11R6/include =20 -- Looking for XOpenDisplay in /usr/X11R6/lib/libX11.so.16.1;/usr/X11R6/lib= /libXext.so.13.0 -- Looking for XOpenDisplay in /usr/X11R6/lib/libX11.so.16.1;/usr/X11R6/lib= /libXext.so.13.0 - found -- Looking for gethostbyname -- Looking for gethostbyname - found -- Looking for connect -- Looking for connect - found -- Looking for remove -- Looking for remove - found -- Looking for shmat -- Looking for shmat - found -- Looking for IceConnectionNumber in ICE -- Looking for IceConnectionNumber in ICE - found -- Found X11: /usr/X11R6/lib/libX11.so.16.1 -- Using glslang install located at /usr/local -- Configuring done -- Generating done -- Build files have been written to: /usr/ports/pobj/vulkan-validation-laye= rs-1.1.106.0/build-amd64 =3D=3D=3D> Building for vulkan-validation-layers-1.1.106.0 [1/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &&= /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/= Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/l= ocal/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registry= vk_extension_helper.h [2/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &&= /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/= Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/l= ocal/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registry= vk_safe_struct.cpp [3/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &&= /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/= Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/l= ocal/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registry= vk_typemap_helper.h [4/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &&= /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/= Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/l= ocal/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registry= vk_object_types.h [5/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &&= /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/= Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/l= ocal/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registry= vk_dispatch_table_helper.h [6/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64/la= yers && /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1= =2E106.0/Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -regist= ry /usr/local/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan= /registry layer_chassis_dispatch.cpp [7/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64/la= yers && /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1= =2E106.0/Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -regist= ry /usr/local/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan= /registry chassis.cpp [8/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64/la= yers && /usr/local/bin/cmake -DINPUT_FILE=3D"/usr/ports/pobj/vulkan-validat= ion-layers-1.1.106.0/Vulkan-ValidationLayers-sdk-1.1.106.0/layers/json/VkLa= yer_standard_validation.json.in" -DOUTPUT_FILE=3D"/usr/ports/pobj/vulkan-va= lidation-layers-1.1.106.0/build-amd64/layers/staging-json/VkLayer_standard_= validation.json" -DVK_VERSION=3D1.1.106 -P /usr/ports/pobj/vulkan-validatio= n-layers-1.1.106.0/build-amd64/layers/generator.cmake [9/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64/la= yers && /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1= =2E106.0/Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/external_revision_ge= nerator.py --from_uuid -s SPIRV_TOOLS_COMMIT_ID -o spirv_tools_commit_id.h [10/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64/l= ayers && /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.= 1.106.0/Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registr= y /usr/local/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/= registry chassis.h [11/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64/l= ayers && /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.= 1.106.0/Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registr= y /usr/local/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/= registry layer_chassis_dispatch.h [12/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &= & /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0= /Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/= local/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registr= y vk_layer_dispatch_table.h [13/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &= & /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0= /Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/= local/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registr= y vk_enum_string_helper.h [14/80] cd /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 &= & /usr/local/bin/python3 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0= /Vulkan-ValidationLayers-sdk-1.1.106.0/scripts/lvl_genvk.py -registry /usr/= local/share/vulkan/registry/vk.xml -scripts /usr/local/share/vulkan/registr= y vk_safe_struct.h [15/80] /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/bin/c++ -DAPI_N= AME=3D\"Vulkan\" -DBUILD_CORE_VALIDATION -DVK_USE_PLATFORM_XCB_KHR -DVK_USE= _PLATFORM_XCB_KHX -DVK_USE_PLATFORM_XLIB_KHR -DVK_USE_PLATFORM_XLIB_KHX -DV= K_USE_PLATFORM_XLIB_XRANDR_EXT -DVkLayer_core_validation_EXPORTS -I/usr/X11= R6/include -I/usr/ports/pobj/vulkan-validation-layers-1.1.106.0/Vulkan-Vali= dationLayers-sdk-1.1.106.0/layers -I/usr/local/include -I. -Ilayers -O2 -pi= pe -fno-rtti -Wpointer-arith -Wno-unused-function -Wno-sign-compare -DNDEBU= G -fPIC -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initialize= rs -fno-strict-aliasing -fno-builtin-memcmp -fvisibility=3Dhidden -std=3Dgn= u++11 -MD -MT layers/CMakeFiles/VkLayer_core_validation.dir/core_validation= =2Ecpp.o -MF layers/CMakeFiles/VkLayer_core_validation.dir/core_validation.= cpp.o.d -o layers/CMakeFiles/VkLayer_core_validation.dir/core_validation.cp= p.o -c /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/Vulkan-Validation= Layers-sdk-1.1.106.0/layers/core_validation.cpp FAILED: layers/CMakeFiles/VkLayer_core_validation.dir/core_validation.cpp.o= =20 /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/bin/c++ -DAPI_NAME=3D\"= Vulkan\" -DBUILD_CORE_VALIDATION -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFOR= M_XCB_KHX -DVK_USE_PLATFORM_XLIB_KHR -DVK_USE_PLATFORM_XLIB_KHX -DVK_USE_PL= ATFORM_XLIB_XRANDR_EXT -DVkLayer_core_validation_EXPORTS -I/usr/X11R6/inclu= de -I/usr/ports/pobj/vulkan-validation-layers-1.1.106.0/Vulkan-ValidationLa= yers-sdk-1.1.106.0/layers -I/usr/local/include -I. -Ilayers -O2 -pipe -fno-= rtti -Wpointer-arith -Wno-unused-function -Wno-sign-compare -DNDEBUG -fPIC = -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fno-= strict-aliasing -fno-builtin-memcmp -fvisibility=3Dhidden -std=3Dgnu++11 -M= D -MT layers/CMakeFiles/VkLayer_core_validation.dir/core_validation.cpp.o -= MF layers/CMakeFiles/VkLayer_core_validation.dir/core_validation.cpp.o.d -o= layers/CMakeFiles/VkLayer_core_validation.dir/core_validation.cpp.o -c /us= r/ports/pobj/vulkan-validation-layers-1.1.106.0/Vulkan-ValidationLayers-sdk= -1.1.106.0/layers/core_validation.cpp /usr/ports/pobj/vulkan-validation-layers-1.1.106.0/Vulkan-ValidationLayers-= sdk-1.1.106.0/layers/core_validation.cpp:11500:31: error: no member named '= vk_khr_surface_protected_capabilities' in 'DeviceExtensions' if (device_extensions.vk_khr_surface_protected_capabilities && ~~~~~~~~~~~~~~~~~ ^ 1 error generated. ninja: build stopped: subcommand failed. *** Error 1 in . (/usr/ports/devel/cmake/cmake.port.mk:39 'do-build': @cd /= usr/ports/pobj/vulkan-validation-layers-1.1.106.0/build-amd64 && ...) *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2796 '/usr/ports= /pobj/vulkan-validation-layers-1.1.106.0/build-amd64/.build_done') *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2021 '/usr/ports= /packages/amd64/all/vulkan-validation-layers-1.1.106.0.tgz') *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2019 '/usr/ports= /packages/amd64/all/vulkan-validation-layers-1.1.106.0.tgz') *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2487 '_internal-= package') *** Error 1 in /tmp/ports/graphics/vulkan-validation-layers (/usr/ports/inf= rastructure/mk/bsd.port.mk:2466 'package')
