On Sat, May 25 2019, Thomas Frohwein <tfrohw...@fastmail.com> wrote:
> Hi,
>
> When trying to download and extract Ultimate Doom to test the gzdoom
> update, I couldn't extract the GOG.com file with our innoextract. Turns
> out that GOG.com has moved forward to creating those with a snapshot
> version of Inno Setup that is not supported by the last release of
> innoextract.
>
> This diff updates the port to the latest snapshot of innoextract that
> specifically addresses the issues with GOG. Of note, this proposed
> update switches from the distfiles of the Homepage to the GitHub
> commit. I am usually against this where possible because of GH's track
> record of changing their on-the-fly tarball creation without notice. I
> looked at the relevant patch history since release to see if we could
> stay with 1.7 and add a patch, but the changes are too complex and
> would make next updates potentially confusing. Therefore, I propose to
> temporarily switch to GH_COMMIT. I placed a comment to switch back when
> possible.
>
> I think this is justified by GOG.com downloads being the main use case
> which is broken in the current state. This update fixes the extraction
> of the Ultimate Doom file.
>
> Is 1.7.20190228 acceptable as the update version number? Feb 28, 2019
> is the date of the GH commit, and the next release will likely be 1.8.
>
> I would like to take MAINTAINER of innoextract while here.
>
> ok?

yep, ok jca@

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to