Hi, audacious-plugins has two issues, that still exist as of 3.10:
- It doesn't build with ports-gcc (macppc [0], sparc64 [1]) The problem here is again a macro vs function issue. I've applied the same thing upstream still does on audacious proper [2]: undef'ing feof(3). Renaming locally feof() in the neon plugin won't help. It would be needed to change the vfs in libaudcore for this, and thus in turn all plugins using libaudcore' feof(). - At least on macppc, it does some white noise during playback After poking around, i've found out it was a bit depth issue when the related audio setting is on "automatic". Setting manually to 16 bit fixed the issue, but it's supposed to work... automatically. mpv does things differently [3] and i have no sound issues (excepted for CDDA) on macppc. So after comparing their work, and reading the sio_open(3) manpage, i've changed some parameters to make it work ootb. While here, i've moved HOMEPAGE to https. Testing: I've tested playing mp3, ogg and wav playback on macppc [4], and amd64 indeed, without issues. Comments/feedback/testing are welcome! Charlène. [0] http://build-failures.rhaalovely.net/powerpc/last/audio/audacious-plugins.log [1] http://build-failures.rhaalovely.net/sparc64/2019-04-14/audio/audacious-plugins.log [2] https://github.com/audacious-media-player/audacious/blob/master/src/libaudcore/vfs.h#L81 [3] https://github.com/mpv-player/mpv/blob/802f594a857c703ac88e946d14b69cd3b6eb6006/stream/ai_sndio.c [4] https://bsd.network/@julianaito/102103780234482431 Index: Makefile =================================================================== RCS file: /cvs/ports/audio/audacious-plugins/Makefile,v retrieving revision 1.77 diff -u -p -u -p -r1.77 Makefile --- Makefile 12 May 2019 15:26:06 -0000 1.77 +++ Makefile 16 May 2019 05:45:09 -0000 @@ -4,11 +4,11 @@ COMMENT = input and output plugins for V = 3.9 DISTNAME = audacious-plugins-$V -REVISION = 2 +REVISION = 3 CATEGORIES = audio multimedia -HOMEPAGE = http://audacious-media-player.org/ +HOMEPAGE = https://audacious-media-player.org/ # BSD / GPL PERMIT_PACKAGE_CDROM = Yes Index: patches/patch-src_neon_neon_cc =================================================================== RCS file: patches/patch-src_neon_neon_cc diff -N patches/patch-src_neon_neon_cc --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-src_neon_neon_cc 16 May 2019 05:45:09 -0000 @@ -0,0 +1,19 @@ +$OpenBSD$ + +Fix for ports-gcc as feof() is a macro there: + +neon.cc:968:16: error: expected unqualified-id before '(' token +bool NeonFile::feof () + +Index: src/neon/neon.cc +--- src/neon/neon.cc.orig ++++ src/neon/neon.cc +@@ -45,6 +45,8 @@ + #define NEON_ICY_BUFSIZE (4096) + #define NEON_RETRY_COUNT 6 + ++#undef feof ++ + enum FillBufferResult { + FILL_BUFFER_SUCCESS, + FILL_BUFFER_ERROR, Index: patches/patch-src_sndio_sndio_cc =================================================================== RCS file: patches/patch-src_sndio_sndio_cc diff -N patches/patch-src_sndio_sndio_cc --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ patches/patch-src_sndio_sndio_cc 16 May 2019 05:45:09 -0000 @@ -0,0 +1,21 @@ +$OpenBSD$ + +Fix playback plagued by white noise on macppc (at least) when +bitrate is on "automatic". + +Index: src/sndio/sndio.cc +--- src/sndio/sndio.cc.orig ++++ src/sndio/sndio.cc +@@ -207,9 +207,9 @@ bool SndioPlugin::open_audio (int format, int rate, in + sio_initpar (& par); + + par.bits = fdata->bits; +- par.bps = fdata->bytes; +- par.sig = fdata->sign; +- par.le = fdata->le; ++ par.bps = SIO_BPS(par.bits); ++ par.sig = 1; ++ par.le = SIO_LE_NATIVE; + par.msb = false; + par.pchan = channels; + par.rate = rate;
