Hi Paco,

I saw this, but I forgot to reply.

I'm all for additional functionality, but FFmpeg in particular I have
been trying to balance functionality, but not try to pull in the
whole kitchen sink too.

I don't really like the idea of pulling this in as it adds a dependency on 3
new libraries. If we go in this direction the diff needs a bunch of additional
changes.


On 5/9/2019 2:38 PM, Paco Esteban wrote:
Hi ports@,

I sent this email to Brad Smith, maintainer of graphics/ffmpeg 2 weeks
ago but did not have any answer.

I'm forwarding it here so maybe somebody can take a look.

Thanks.

----- Forwarded message -----

...

I had a problem the other day trying to watch a video stream using mpv
(and later tried ffplay). I discovered that the OpenBSD package for
ffmpeg does not support DASH demuxing, and that was the problem.

I prepared a diff to add that support, find it at the end of the email.

Just one thing, I'm not so experienced with ports (just built one and
was really easy). I have a message like this when creating the package:

   LIB_DEPENDS textproc/libxml not needed for graphics/ffmpeg ?

I added that dependency myself, because DASH support is enabled via
--enable-libxml2 at configure time ...
Am I doing something wrong ?

Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/ffmpeg/Makefile,v
retrieving revision 1.182
diff -u -p -r1.182 Makefile
--- Makefile    2 Apr 2019 18:42:11 -0000       1.182
+++ Makefile    26 Apr 2019 08:05:11 -0000
@@ -8,6 +8,7 @@ CATEGORIES=     graphics multimedia
  MASTER_SITES=  https://ffmpeg.org/releases/
  EXTRACT_SUFX=  .tar.xz
  EPOCH=         0
+REVISION=      0

  SHARED_LIBS=   avcodec         23.0 \
                 avdevice        11.0 \
@@ -50,7 +51,8 @@ LIB_DEPENDS=  archivers/bzip2 \
                 multimedia/libvpx \
                 multimedia/x264 \
                 multimedia/x265 \
-               multimedia/xvidcore
+               multimedia/xvidcore \
+               textproc/libxml

  # inter-library dependencies for the current configuration
  LIBavcodec_EXTRALIBS=-L${LOCALBASE}/lib -ldav1d -lgsm -lmp3lame -lopus 
-lspeex -lvorbis -lvorbisenc -lvpx -lx264 -lx265 -lxvidcore -lm -lz -pthread
@@ -109,6 +111,7 @@ CONFIGURE_ARGS+= --enable-shared \
                 --enable-libx264 \
                 --enable-libx265 \
                 --enable-libxvid \
+               --enable-libxml2 \
                 --enable-nonfree \
                 --enable-openssl \
                 --extra-cflags="-I${LOCALBASE}/include -I${X11BASE}/include" \

...
----- End forwarded message -----


Reply via email to