On Tue, May 07 2019, Timothy Brown <tbr...@freeshell.org> wrote:
> Hi all,
>
> Here's an update to productivity/mcds
> Notable changes are:
> - Ability to use a GPG encrypted password file.
> This can be turned off with a no_gpgme flavor.
> - Uses pledge() and unveil() if available.
> - Updated manpage (thanks Stephen Gregoratto!).
>
> This is the first time I'm using a FLAVOR so if anything
> jumps out as stange or incorrect please let me know.
>
> Once again comments, thoughts?
My first thought was: "why add a FLAVOR?". If gpg/gpgme support is the
only way to avoid the need of plaintext credentials, maybe it should be
enabled by default?
(NB: I don't use that port)
> Thanks!
> Tim
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/productivity/mcds/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile 2 May 2019 15:52:58 -0000 1.1.1.1
> +++ Makefile 7 May 2019 21:50:44 -0000
> @@ -2,7 +2,7 @@
>
> COMMENT = tty-based carddav search tool
>
> -V = 0.9
> +V = 1.2
> DISTNAME = mcds-${V}
> CATEGORIES = productivity
>
> @@ -22,5 +22,15 @@ LIB_DEPENDS = devel/gettext \
> CONFIGURE_STYLE = gnu
>
> NO_TEST = Yes
> +
> +FLAVORS = no_gpgme
> +FLAVOR ?=
> +
> +.if ${FLAVOR:L:Mno_gpgme}
> +CONFIGURE_ARGS += --disable-gpgme
> +.else
> +WANTLIB += assuan gpg-error gpgme
> +LIB_DEPENDS += security/gpgme
> +.endif
>
> .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/productivity/mcds/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo 2 May 2019 15:52:58 -0000 1.1.1.1
> +++ distinfo 7 May 2019 21:50:44 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (mcds-0.9.tar.gz) = p+H8Q94kiHDDo/pV570uCXZki5YnyC41tUDx8HgARKc=
> -SIZE (mcds-0.9.tar.gz) = 194620
> +SHA256 (mcds-1.2.tar.gz) = XvOuh5IgjdWF1BPE/mowwCv8BKY4l/nvmnzZEK4Pbx4=
> +SIZE (mcds-1.2.tar.gz) = 201027
>
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
