On Wed, May 08 2019, Alessandro DE LAURENZIS <jus...@atlantide.t28.net> wrote:
> Hello Jeremie,
>
> thanks for the time you spent to look into this.
>
> On 06/05/2019 16:34, Jeremie Courreges-Anglas wrote:
> [...]
>> gcc errors out because for ANSI C, C++ comments are an extension
>> disabled by -std=c89. To enable extensions, one should use -std=gnu89.
>> This fixes the build with gcc. ok?
>>
>>
>> Index: Makefile
>> ===================================================================
>> RCS file: /cvs/ports/cad/netgen/Makefile,v
>> retrieving revision 1.2
>> diff -u -p -r1.2 Makefile
>> --- Makefile 28 Apr 2019 20:51:27 -0000 1.2
>> +++ Makefile 6 May 2019 14:31:24 -0000
>> @@ -31,7 +31,7 @@ PATCHORIG = .patch.orig
>> WRKCONF = ${WRKSRC}/scripts
>> CONFIGURE_STYLE = gnu
>> CONFIGURE_ENV = CPPFLAGS="-I${X11BASE}/include" \
>> - CFLAGS="-std=c89 ${CFLAGS}"
>> + CFLAGS="-std=gnu89 ${CFLAGS}"
>> CONFIGURE_ARGS = --with-tcl=${MODTCL_LIBDIR} \
>> --with-tk=${MODTK_LIBDIR}
>
> Sure, that looks good to me. Is the REVISION bump needed?
Not needed in my opinion because it doesn't seem to affect the way clang
builds those files and because the port didn't build with gcc anyway.
But since you and a developer asked about it, I'll just bump it.
Committed, thanks.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
