Hi,
On Wed, 1 May 2019 21:44:22 +0200
Landry Breuil <lan...@openbsd.org> wrote:
> On Sun, Apr 28, 2019 at 09:52:35AM +0200, Landry Breuil wrote:
> > Hi,
> >
> > now that we have ffmpeg 4 & gcc 8, there should be no blocker
> > anymore for updating mpd to the latest version of the 0.21 branch.
> > All configure options changed since the switch to meson, i tried to
> > keep them the same.
> > might take maintainership, after all i've been using mpd for at
> > least 12 years now...
> >
> > runtime tests welcome on gcc archs of course :)
>
> New diff, with correctly removed patches (hopefully). cvs sucks.
There are undefined references errors on macppc because of --as-needed,
it probably impacts all ld.bfd archs. Courtesy of Jeremie who met this
on another port in the past, here is what you should add to the
Makefile:
--8<--
# disable meson's default of using "-Wl,--as-needed" on ld.bfd arches;
# build failures due to undefined references are often seen.
.include <bsd.port.arch.mk>
.if !${PROPERTIES:Mlld}
CONFIGURE_ARGS += -Db_asneeded=false
.endif
-->8--
This fixes the build. ncmpc works without issues.
I'm not joining a full diff because i use edd@'s libcdio update in
that partial bulk and it changes depends. mpd 0.20 has been built with
the libcdio/libcdio-paranoia update in my previous partial bulk, so i
don't think it's due to libcdio.
Error log:
/usr/bin/ld: Warning: gc-sections option ignored
src/archive/plugins/libarchive_plugins.a(Iso9660ArchivePlugin.cxx.o): In
function `Iso9660ArchiveFile::OpenStream(char const*, Mutex&)':
Iso9660ArchivePlugin.cxx:(.text+0x13c): undefined reference to
`iso9660_ifs_stat_translate'
src/archive/plugins/libarchive_plugins.a(Iso9660ArchivePlugin.cxx.o): In
function `Iso9660InputStream::Read(void*, unsigned long)':
Iso9660ArchivePlugin.cxx:(.text+0x4fc): undefined reference to
`iso9660_iso_seek_read'
src/archive/plugins/libarchive_plugins.a(Iso9660ArchivePlugin.cxx.o): In
function `Iso9660ArchiveFile::Visit(ArchiveVisitor&)':
Iso9660ArchivePlugin.cxx:(.text+0x5f4): undefined reference to
`iso9660_ifs_readdir'
Iso9660ArchivePlugin.cxx:(.text+0x710): undefined reference to
`iso9660_filelist_free'
Iso9660ArchivePlugin.cxx:(.text+0x764): undefined reference to
`iso9660_ifs_readdir'
Iso9660ArchivePlugin.cxx:(.text+0x81c): undefined reference to
`iso9660_filelist_free'
Iso9660ArchivePlugin.cxx:(.text+0x834): undefined reference to
`iso9660_ifs_readdir'
Iso9660ArchivePlugin.cxx:(.text+0x8fc): undefined reference to
`iso9660_filelist_free'
Iso9660ArchivePlugin.cxx:(.text+0x914): undefined reference to
`iso9660_ifs_readdir'
Iso9660ArchivePlugin.cxx:(.text+0x9ec): undefined reference to
`iso9660_filelist_free'
src/archive/plugins/libarchive_plugins.a(Iso9660ArchivePlugin.cxx.o): In
function `_ZL20iso9660_archive_open4Path':
Iso9660ArchivePlugin.cxx:(.text+0xabc): undefined reference to `iso9660_open'
src/archive/plugins/libarchive_plugins.a(Iso9660ArchivePlugin.cxx.o): In
function `std::_Sp_counted_ptr_inplace<Iso9660, std::allocator<Iso9660>,
(__gnu_cxx::_Lock_policy)2>::_M_dispose()':
Iso9660ArchivePlugin.cxx:(.text._ZNSt23_Sp_counted_ptr_inplaceI7Iso9660SaIS0_ELN9__gnu_cxx12_Lock_policyE2EE10_M_disposeEv[_ZNSt23_Sp_counted_ptr_inplaceI7Iso9660SaIS0_ELN9__gnu_cxx12_Lock_policyE2EE10_M_disposeEv]+0x24):
undefined reference to `iso9660_close'
src/archive/plugins/libarchive_plugins.a(Iso9660ArchivePlugin.cxx.o): In
function `Iso9660ArchiveFile::Visit(char*, unsigned long, unsigned long,
ArchiveVisitor&)':
Iso9660ArchivePlugin.cxx:(.text._ZN18Iso9660ArchiveFile5VisitEPcmmR14ArchiveVisitor[_ZN18Iso9660ArchiveFile5VisitEPcmmR14ArchiveVisitor]+0x54):
undefined reference to `iso9660_ifs_readdir'
Iso9660ArchivePlugin.cxx:(.text._ZN18Iso9660ArchiveFile5VisitEPcmmR14ArchiveVisitor[_ZN18Iso9660ArchiveFile5VisitEPcmmR14ArchiveVisitor]+0x154):
undefined reference to `iso9660_filelist_free
