With newer libupnp, the old amule, which saw its last release in 2016,
no longer builds.

I don't feel like diving into this code so I've simply disabled UPnP
support.

Are there any serious eMule users around that rely on UPnP and want to
fix it?  Should we keep it enabled (and stick with the old libupnp)?

I went for the easy way because I do not want such old ports block new
development, but I might as well be alone with this limited view.

Thoughts?

Build tested on amd64, "All 9 tests passed" in regress.

Index: net/amule/Makefile
===================================================================
RCS file: /cvs/ports/net/amule/Makefile,v
retrieving revision 1.70
diff -u -p -r1.70 Makefile
--- net/amule/Makefile  20 Jan 2019 22:02:02 -0000      1.70
+++ net/amule/Makefile  27 Apr 2019 09:46:47 -0000
@@ -6,7 +6,7 @@ COMMENT-daemon =stand-alone daemon/cmdli
 
 V =            2.3.2
 DISTNAME =     aMule-$V
-REVISION =     12
+REVISION =     13
 CATEGORIES =   net
 
 HOMEPAGE =     http://www.amule.org/
@@ -34,8 +34,7 @@ COMPILER =            base-clang ports-gcc base-gc
 BUILD_DEPENDS =                devel/bison \
                        devel/gettext-tools
 
-commonLIB_DEPENDS =    x11/wxWidgets>=3.0.4 \
-                       net/libupnp>=1.6.6
+commonLIB_DEPENDS =    x11/wxWidgets>=3.0.4
 
 LIB_DEPENDS-main =     ${LIB_DEPENDS} ${commonLIB_DEPENDS} \
                        converters/libiconv \
@@ -52,7 +51,7 @@ LIB_DEPENDS-web =     ${LIB_DEPENDS} ${commo
 RUN_DEPENDS-main =     ${RUN_DEPENDS} \
                        devel/desktop-file-utils
 
-commonWANTLIB =                c ixml m pthread ${COMPILER_LIBCXX} threadutil 
upnp \
+commonWANTLIB =                c ixml m pthread ${COMPILER_LIBCXX} \
                        z wx_baseu-3.0 wx_baseu_net-3.0
 WANTLIB-main =         ${WANTLIB} ${commonWANTLIB} \
                        GeoIP X11 cryptopp fontconfig tiff webp \
@@ -72,6 +71,7 @@ AUTOCONF_VERSION =    2.65
 CONFIGURE_ARGS =       --disable-optimize \
                        --disable-profile \
                        --disable-plasmamule \
+                       --disable-upnp \
                        --disable-xas \
                        --enable-alc \
                        --enable-alcc \
Index: net/amule/pkg/PLIST-main
===================================================================
RCS file: /cvs/ports/net/amule/pkg/PLIST-main,v
retrieving revision 1.10
diff -u -p -r1.10 PLIST-main
--- net/amule/pkg/PLIST-main    27 Jun 2018 21:03:58 -0000      1.10
+++ net/amule/pkg/PLIST-main    27 Apr 2019 10:05:39 -0000
@@ -23,7 +23,6 @@ share/amule/skins/kde4.zip
 share/amule/skins/priscilla.zip
 share/amule/skins/tango.zip
 share/amule/skins/xfce.zip
-share/applications/
 share/applications/alc.desktop
 share/applications/amule.desktop
 share/applications/amulegui.desktop

Reply via email to