Hi Stefan,

Stefan Sperling writes:
> -VERSION=     0.6
> +# Yes, upstream recommends this "prealpha" release.
> +# Which, by the way, is also shipped in Debian stable...
> +VERSION=     5prealpha
> +EPOCH=               0

5 is greater than 0.6, so this doesn't need EPOCH.

>  DISTNAME=    sphinxbase-${VERSION}
> -PKGNAME=     cmu-sphinxbase-${VERSION}
> -REVISION=    5
> +# Translate upstream's bonkers release name into something which
> +# our pkg tools will find palatable...
> +PKGNAME=     cmu-sphinxbase-${VERSION:S/prealpha/-pre0/}

-pre0 can't start with a hyphen; see packages-specs(7).

> -HOMEPAGE=    http://cmusphinx.sourceforge.net/
> +HOMEPAGE=    https://cmusphinx.sourceforge.net/

Subdomains of sourceforge.net never support https. Please use the
github.io subdomain that the original HOMEPAGE now redirects to.

> -MASTER_SITES=        ${MASTER_SITE_SOURCEFORGE:=cmusphinx/}
> +MASTER_SITES=        
> ${MASTER_SITE_SOURCEFORGE:=cmusphinx/sphinxbase/${VERSION}/}

Not needed.

> +WANTLIB=     blas c lapack m pthread sndio ${MODFORTRAN_WANTLIB} \
> +             ${MODPY_WANTLIB}
> (...)
> +LIB_DEPENDS= math/lapack \
> +             ${MODFORTRAN_LIB_DEPENDS} \
> +             ${MODPY_LIB_DEPENDS}
> +RUN_DEPENDS= ${MODPY_RUN_DEPENDS}

MODPY_WANTLIB and MODPY_LIB_DEPENDS are only needed if something links
against libpython2.7.so. "make port-lib-depends-check" says nothing does.

The Python module automatically adds to RUN_DEPENDS too (port-modules(5)).

-- 
Anthony J. Bentley

Reply via email to