On Sat, Apr 20 2019, Thomas Frohwein <tfrohw...@fastmail.com> wrote:
> ping - catch up with sdl2-mixer for 6.6?
One minor nit,
> On Sat, Jan 19, 2019 at 03:00:58PM -0800, Thomas Frohwein wrote:
>> Hi,
>>
>> This diff updates sdl2-mixer from 2.0.2 to 2.0.4. Main changes are
>> addition of Opus support via audio/opusfile and some bugfixes. Official
>> changelog [1]:
>>
>> 2.0.4:
>> * Removed smpeg support for mp3 music, now that it's replaced by libmpg123
>> * Fixed mp3 mad decoder to skip tags, which otherwise would lead to crashes
>> * Added support for Opus music playback using opusfile library
>>
>> 2.0.3:
>> * Fixed regression where Mix_Init() would return 0 for available music
>> formats
>>
>> Bump minor because of symbol additions. The output of check_sym:
>>
>> /usr/local/lib/libSDL2_mixer.so.0.0 -->
>> /usr/ports/pobj/sdl2-mixer-2.0.4/SDL2_mixer-2.0.4/build/.libs/libSDL2_mixer.so.0.1
>> No dynamic export changes
>> External reference changes:
>> added:
>> SDL_Log
>> SDL_strcmp
>> op_free
>> op_head
>> op_open_callbacks
>> op_pcm_seek
>> op_read
>> op_seekable
check_sym shows no "Dynamic export changes", this alone doesn't warrant
a minor bump. A diff of the installed headers shows new possible values
for two enums (related to opus support). I would bump the minor to
ensure that possible consumers of the new enum values use the library
they were built against.
While here I would sync the shlib version used upstream, see
${WRKSRC}/shared_libs.log:
SHARED_LIBS = SDL2_mixer 0.1 # 2.2
Diff looks good ports-wise, ok jca@ since you've tested multiple
consumers.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
