On Wed, Apr 10 2019, Charlene Wendling <juliana...@posteo.jp> wrote:
> Hi ports,
>
> (This is for post-unlock.)
>
> spacehulk breaks during the build with ports-gcc-8:
>
> smtp.cpp:291:1: error: narrowing conversion of '-1' from 'int' to
> 'char' inside { } [-Wnarrowing]
>
> On powerpc and arm, char is unsigned by default, so it breaks.
>
> There is a bit of mystery on why it works with gcc-4.9, it seems
> that gcc-8 is better at finding narrowing errors.
>
> That diff fixes the issue and has been tested on amd64 and indeed
> powerpc. While here, i've cleaned up the spacing in the Makefile.
fwiw cvs diff -w Makefile shows only a REVISION bump.
The diff makes sense, ok jca@ post unlock, no opinion wrt 6.5.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
