On Sat, Mar 02 2019, Charlene Wendling <[email protected]> wrote:
> On Fri, 1 Mar 2019 23:03:00 +0000
> Stuart Henderson wrote:
>
>> On 2019/03/01 23:49, Charlene Wendling wrote:
>> > 
>> > > http://build-failures.rhaalovely.net/powerpc/2019-02-04/games/spacehulk.log
>> > > http://build-failures.rhaalovely.net/sparc64/2019-02-03/games/spacehulk.log
>> > 
>> > It was just a single missing header. While doing a checkup of the
>> > port, i noticed that WANTLIB needed a major refresh as well. 
>> > 
>> > It builds and works fine on macppc [1] and amd64. 
>> 
>> Hmm, at some points in the code it's using srand (via setSeed) to try
>> to set a specific seed from a save file, presumably to recreate game
>> state. If that's correct then this should be patched to use
>> srand_deterministic(), see rand(3) for an explanation.
>
> Thanks! It's the case.
>
> In WRKSRC/src/datastoring.cpp, DataStoring::LoadFromContent calls 
> DataStoring::LoadGameManager, fetching the seed from the given
> save file.
>
> I've changed the patch accordingly. 

LGTM, ok jca@

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to