Re: UPDATE: security/aircrack-ng to 1.5.2

[Benoit Lecocq]

On 2/1/19 11:16 PM, Sebastian Reitenbach wrote:

Am Dienstag, Januar 29, 2019 16:29 CET, "Sebastian Reitenbach" 
<sebas...@l00-bugdead-prods.de> schrieb:

Hi,

I think I addressed all the comments/concerns:
  * homepage and mastersite HTTPS
  * run autoreconfig in do-gen: stage
  * fix to use base libtool (had to patch Makefile.am to explicitly add library 
our base libtool did
     not find)
  * don't install airtun-ng manpage
  * added LIBTOOL_FLAGS to disable static libs
  * the libaircrack-crypto* libraries are loaded via dlopen, however there seem 
to be some
     of them arch-dependent I only tested building on amd64 and i386, so didn't 
spotted it
  * Added PFRAG.ARCH for x86, ppc and arm
  * added RUN_DEPENDS to mac-vendors package, and point airodump-ng to that OUI 
file,
    therefore the README is obsolete, so deleted it
  * I haven't seen anything to put the crypto libraries into a subdirectory

In src/aircrack-util/crypto_engine_loader.c there is this:
         if (simd_features & SIMD_SUPPORTS_AVX512F)
         {
                 strncat(buffer, "-x86-avx512", buffer_remaining);
         }
         else if (simd_features & SIMD_SUPPORTS_AVX2)
         {
                 strncat(buffer, "-x86-avx2", buffer_remaining);
         }
         else if (simd_features & SIMD_SUPPORTS_AVX)
         {
                 strncat(buffer, "-x86-avx", buffer_remaining);
         }
         else if (simd_features & SIMD_SUPPORTS_SSE2)
         {
                 strncat(buffer, "-x86-sse2", buffer_remaining);
         }
         else if (simd_features & SIMD_SUPPORTS_ASIMD)
         {
                 strncat(buffer, "-arm-neon", buffer_remaining);
         }
         else if (simd_features & SIMD_SUPPORTS_NEON)
         {
                 strncat(buffer, "-arm-neon", buffer_remaining);
         }
         else if (simd_features & SIMD_SUPPORTS_POWER8)
         {
                 strncat(buffer, "-ppc-power8", buffer_remaining);
         }
         else if (simd_features & SIMD_SUPPORTS_ALTIVEC)
         {
                 strncat(buffer, "-ppc-altivec", buffer_remaining);
         }

So I guess the arm crypto libs only built on arm, and ppc-* libs only build
on macppc. Don't know if the arm- one would also be created on aarch64?I don't 
have a working macppc anymore, and don't have any arm type
device around to test there, so tests on other platforms and with otherdevices 
(I only tested with rum(4)) welcome.

updated version attached.

in the meantime also tested with athn on i386, working as well as the rum.

tested on amd64, ok benoit@

cheers,
Sebastian