On 2019/02/20 18:41, Alexander Bluhm wrote: > On Tue, Feb 19, 2019 at 12:02:25PM +0100, Frederic Cambus wrote: > > Here is a new port: net/p5-MaxMind-DB-Writer. > > > > Comments? OK? > > You have a "WANTLIB += ", I think "WANTLIB = " is better as the > value is is set, not added.
This is common from 'make port-lib-depends-check', it is like this all over the tree. > The module requires "MaxMind::DB::Common" => "0.031003". So please > write net/p5-MaxMind-DB-Common>=0.031003 into RUN_DEPENDS. > > You don't have to add things to TEST_DEPENDS that are already in > RUN_DEPENDS. cpan.port.mk includes RUN_DEPENDS in TEST_DEPENDS. > > with that, OK bluhm@ >
