On 2019/02/20 01:59, Kurt Mosiejczuk wrote:
> On Wed, Feb 06, 2019 at 04:46:50PM -0500, Kurt Mosiejczuk wrote:
> > This seems to be a simple point release update. There isn't a changelog,
> > but looking through github the change seems to be a fix for handling
> > an empty string being handed to it.
>
> > The packages depended on itself for testing? So it insisted I install the
> > package in order to test itself. Then when I checked that the behavior
> > on 1.6.0 was the same and I could no longer run the test, even after
> > deletig the 1.6.0 package from my system. Deleting that self-dependency
> > allowed me to run the tests, which all passed.
>
> > There don't seem to be any ports that depend on this, so no testing
> > to do there. (Which might mean we don't need this port any more?)
>
> Ping?
>
> --Kurt
>
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/security/py-aes/Makefile,v
> > retrieving revision 1.1.1.1
> > diff -u -p -r1.1.1.1 Makefile
> > --- Makefile 9 Jul 2018 05:36:45 -0000 1.1.1.1
> > +++ Makefile 6 Feb 2019 21:35:05 -0000
> > @@ -2,7 +2,7 @@
> >
> > COMMENT = pure-Python implementation of AES block-cipher
> >
> > -MODPY_EGG_VERSION = 1.6.0
> > +MODPY_EGG_VERSION = 1.6.1
> > DISTNAME = pyaes-${MODPY_EGG_VERSION}
> > PKGNAME = py-aes-${MODPY_EGG_VERSION}
> >
> > @@ -16,8 +16,6 @@ MODPY_PI = Yes
> >
> > FLAVORS = python3
> > FLAVOR ?=
> > -
> > -TEST_DEPENDS = ${FULLPKGNAME}:${FULLPKGPATH}
> >
> > do-test:
> > @cd ${WRKSRC} && \
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/security/py-aes/distinfo,v
> > retrieving revision 1.1.1.1
> > diff -u -p -r1.1.1.1 distinfo
> > --- distinfo 9 Jul 2018 05:36:45 -0000 1.1.1.1
> > +++ distinfo 6 Feb 2019 21:35:05 -0000
> > @@ -1,2 +1,2 @@
> > -SHA256 (pyaes-1.6.0.tar.gz) = nNWlTZFLHuv7FPy0kDFSFLagME2fG7R+kNHY4LFc6S4=
> > -SIZE (pyaes-1.6.0.tar.gz) = 28237
> > +SHA256 (pyaes-1.6.1.tar.gz) = AsGxQFw408NwsIX7lS3YvqP63O5kEa2Z8xLMEpxTbY8=
> > +SIZE (pyaes-1.6.1.tar.gz) = 28536
> >
>
Committed without the TEST_DEPENDS change, that is still needed,
otherwise you get this
===> Regression tests for py-aes-1.6.1
Traceback (most recent call last):
File "tests/test-blockfeeder.py", line 36, in <module>
import pyaes
ImportError: No module named pyaes
It is pretty common for python ports to require that they're
self-installed for tests to run.
"could no longer run the test", make sure you don't have a different
version of the port earlier in your PORTSDIR_PATH, that's exactly why
I suggest doing updates directly in /usr/ports rather than mystuff.
