On 2019/02/15 19:28, Raphael Graf wrote:
> There are lots of changes since 3.04.00:
> https://github.com/tesseract-ocr/tesseract/wiki/ReleaseNotes
> 
> I have tested on amd64 and macppc, the result look very good.
> The following dependent ports still compile:
> graphics/pdfsandwich
> mail/p5-FuzzyOcr
> multimedia/ogmrip
> x11/gnome/ocrfeeder
> (at least pdfsandwich and ocrfeeder seem to work)
> 
> The tessdata packages use the language data files from the 'tessdata_fast'
> repository: https://github.com/tesseract-ocr/tessdata_fast
> From the README:
> "Most users will want to use these traineddata files to do OCR and these will
> be shipped as part of Linux distributions .."
> 
> Unfortunately, the git-submodules required for running the tests are not
> included in the distfile, so NO_TEST is set to Yes.
> 
> I am unsure if the PLIST-* files need a @conflict line, can anyone tell?
> 
> The DESCR-* text could be improved, but I find the 1995 sentence kind of 
> funny.
> 
> Any comments?

>From a read-through:

> +# The tests require additional git submodules
> +NO_TEST=     Yes

It should be possible to fetch those as supplemental distfiles -
it's useful to have tests where possible ..

> Index: tessdata/Makefile
> ===================================================================
..
> -EPOCH-main=          0
> -EPOCH-dan=           0
> -EPOCH-fra=           0
> -EPOCH-lav=           0
> -EPOCH-ron=           0
> -EPOCH-swe=           0
> -EPOCH-bul=           0
> -EPOCH-dan_frak=              0
> -EPOCH-hun=           0
> -EPOCH-lit=           0
> -EPOCH-rus=           0
> -EPOCH-tgl=           0
> -EPOCH-cat=           0
> -EPOCH-deu=           0
> -EPOCH-ind=           0
> -EPOCH-nld=           0
> -EPOCH-slk=           0
> -EPOCH-tur=           0
> -EPOCH-ces=           0
> -EPOCH-ell=           0
> -EPOCH-ita=           0
> -EPOCH-nor=           0
> -EPOCH-slv=           0
> -EPOCH-ukr=           0
> -EPOCH-chi_sim=               0
> -EPOCH-jpn=           0
> -EPOCH-pol=           0
> -EPOCH-spa=           0
> -EPOCH-vie=           0
> -EPOCH-chi_tra=               0
> -EPOCH-fin=           0
> -EPOCH-kor=           0
> -EPOCH-por=           0
> -EPOCH-srp=           0
> -REVISION=            1
> +EPOCH=                       1

no need to bump EPOCHs, the version number doesn't go backwards.
I would be tempted to replace all the separate EPOCH-foo with just a
plain EPOCH=0 though.

[various files]
>  share/tessdata/
> -@conflict tesseract-<3.02.02
> -@pkgpath graphics/tesseract,-bul
> -@pkgpath graphics/tesseract-langs/bul

The existing @conflict/@pkgpath lines should stay.

>  pre-configure:
>       cd ${WRKSRC} && ${SETENV} \
>               AUTOCONF_VERSION=${AUTOCONF_VERSION} \
>               AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
>               autoreconf -fi

please replace with the new style:

do-gen:
        cd ${WRKSRC} && ${AUTOCONF_ENV} autoreconf -fi

Reply via email to