On Fri, Feb 15, 2019 at 07:07:40AM +0100, Bj??rn Ketelaars wrote:
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/news/sabnzbd/Makefile,v
> > retrieving revision 1.16
> > diff -u -p -u -r1.16 Makefile
> > --- Makefile        16 Jan 2019 10:51:35 -0000      1.16
> > +++ Makefile        14 Feb 2019 20:25:38 -0000
> > @@ -7,6 +7,7 @@ PKGNAME =                   sabnzbd-${VERSION}
> >  CATEGORIES =                       news
> >  HOMEPAGE =                 https://sabnzbd.org/
> >  MAINTAINER =                       Bjorn Ketelaars <b...@openbsd.org>
> > +REVISION =                 0
> >  
> >  # GPLv2
> >  PERMIT_PACKAGE_CDROM =             Yes
> > @@ -22,7 +23,8 @@ RUN_DEPENDS =                     archivers/par2cmdline \
> >                             archivers/unzip \
> >                             devel/py-cheetah \
> >                             devel/py-notify \
> > -                           news/py-yenc \
> > +                           textproc/py-lxml \
> 
> Are you sure that sabnzbd requires py-lxml, and not a plug-in of some
> sort you are using locally?
> 
> $ cd /usr/ports/news/sabnzbd
> $ grep -r lxml $(make show=WRKSRC) | wc -l
>        0
> 
> Also, there is no mentioning of py-lxml in
> https://github.com/sabnzbd/sabnzbd/blob/2.3.x/INSTALL.txt

Yes, you are right. Back in the day when I was updating sabnzbd and
creating a port of py-sabyenc, I also created couchpotato port and
misplaced my todo items in the wrong port. It's CouchPotato which
needs py-lxml and not SABnzbd. Here is updated patch:

Index: Makefile
===================================================================
RCS file: /cvs/ports/news/sabnzbd/Makefile,v
retrieving revision 1.16
diff -u -p -u -r1.16 Makefile
--- Makefile    16 Jan 2019 10:51:35 -0000      1.16
+++ Makefile    15 Feb 2019 09:12:33 -0000
@@ -7,6 +7,7 @@ PKGNAME =                       sabnzbd-${VERSION}
 CATEGORIES =                   news
 HOMEPAGE =                     https://sabnzbd.org/
 MAINTAINER =                   Bjorn Ketelaars <b...@openbsd.org>
+REVISION =                     0
 
 # GPLv2
 PERMIT_PACKAGE_CDROM =         Yes
@@ -22,7 +23,7 @@ RUN_DEPENDS =                 archivers/par2cmdline \
                                archivers/unzip \
                                devel/py-cheetah \
                                devel/py-notify \
-                               news/py-yenc \
+                               news/py-sabyenc \
                                security/py-cryptography \
                                security/py-openssl
 

-- 
Regards,
 Mikolaj

Reply via email to