On Thu, Feb 07, 2019 at 01:09:30PM +0100, Charlene Wendling wrote:
> On Tue, 5 Feb 2019 13:02:52 +0100
> Charlene Wendling wrote:
> 
> > This hasn't been tested elsewhere that on macppc for now, and i needed
> > to do a make clean=plist before make package. I can't guarantee it's
> > perfect, but i felt like it was time to share it, to avoid duplicating
> > our work. 
> 
> My change to SUBST_VARS made VERSION not being expanded, actually
> breaking packaging with the other x11/qt5 ports includig ${VERSION}
> in PLISTs.
> 
> I'm joining a new diff that fixes that on my macppc and amd64 machines.

If the PLIST doesnt change on x86 then no bump is needed, and since it
didnt package before on !x86 no bump is needed there either. I like this
diff - ok for me.

Reply via email to