On Wed, 9 Jan 2019 07:59:47 +0000
Nigel wrote:
> Ok,
>
> I see you have joined porting perl ports, so welcome.
Thanks!
> If you would
> like to update CVS with this port go ahead, if not I should still be
> able to do this just let me know. I've left it a while to allow for
> any other comments.
>
> For me just include ok nigel@ as comment plus any others like sthen@,
> naddy@ etc. If was doing this I would put cwen@ as author of changes
> in the CVS comment.
>
Unless you're in a rush, i'll commit it.
I'm ccing afresh1@ and giovanni@ to avoid noise, i'll do
www/p5-Catalyst-Plugin-Static-Simple and devel/p5-FileHandle-Unget as
well.
Charlène.
>
> On 01/08/19 08:53, Charlene Wendling wrote:
> > On Mon, 7 Jan 2019 23:17:05 +0000
> > Nigel Taylor wrote:
> >
> >> I had this update from nearly 1yr ago...
> >>
> >> $ cvs -R -q diff -uNp
> >> Index: Makefile
> >> ===================================================================
> >> RCS file: /home/cvs/ports/www/p5-HTML-Tree/Makefile,v
> >> retrieving revision 1.28
> >> diff -u -p -r1.28 Makefile
> >> --- Makefile 1 May 2017 19:54:18 -0000 1.28
> >> +++ Makefile 11 Feb 2018 22:55:22 -0000
> >> @@ -4,7 +4,7 @@ COMMENT= perl parser that builds an HTML
> >>
> >> MODULES= cpan
> >> PKG_ARCH= *
> >> -DISTNAME = HTML-Tree-5.06
> >> +DISTNAME = HTML-Tree-5.07
> >> CATEGORIES= www
> >>
> >> # Perl
> >> Index: distinfo
> >> ===================================================================
> >> RCS file: /home/cvs/ports/www/p5-HTML-Tree/distinfo,v
> >> retrieving revision 1.11
> >> diff -u -p -r1.11 distinfo
> >> --- distinfo 1 May 2017 19:54:18 -0000 1.11
> >> +++ distinfo 11 Feb 2018 22:49:21 -0000
> >> @@ -1,2 +1,2 @@
> >> -SHA256 (HTML-Tree-5.06.tar.gz) =
> >> nDbrGcvfmlkGyFiUjKUcNb11YfUswYxDKBrL5XMnU24=
> >> -SIZE (HTML-Tree-5.06.tar.gz) = 150067
> >> +SHA256 (HTML-Tree-5.07.tar.gz) =
> >> 8DdNuEcxwgS4bB1bkJdf7w0wqGvZ3vkZND5VTjGp278=
> >> +SIZE (HTML-Tree-5.07.tar.gz) = 150477
> >>
> >> The tests passed here on amd64 using the above.
> >>
> >> You shouldn't add p5-libwww without changing the BUILD/RUN_DEPENDS
> >> to only include p5-libwww for runtime, this stops p5-libwww and
> >> all it's run time dependencies having to be built first on build
> >> machines, it has a lot of dependencies.
> >>
> >> Additionally it also promotes some bad habits of not including the
> >> dependencies starting to rely on p5-HTML-Tree rather than including
> >> p5-libwww as a dependency, and also if include p5-libwww alone you
> >> don't get https support you need to add p5-LWP-Protocol-https not
> >> p5-libwww
> >>
> >> p5-libwww used to include https support but was split into a
> >> number of separate modules.
> >>
> >> Something being in the ports tree doesn't make it a reason to
> >> include if it's only recommended. Your taking away the option from
> >> the end user of the ports of deciding if something is actually
> >> needed.
> >
> >
> > Hi Nigel,
> >
> > I didn't see things this way, you're right. Thanks!
> >
> > Charlène.
> >
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/www/p5-HTML-Tree/Makefile,v
> > retrieving revision 1.28
> > diff -u -p -u -p -r1.28 Makefile
> > --- Makefile 1 May 2017 19:54:18 -0000 1.28
> > +++ Makefile 8 Jan 2019 08:41:58 -0000
> > @@ -4,7 +4,7 @@ COMMENT= perl parser that builds an HTML
> >
> > MODULES= cpan
> > PKG_ARCH= *
> > -DISTNAME = HTML-Tree-5.06
> > +DISTNAME = HTML-Tree-5.07
> > CATEGORIES= www
> >
> > # Perl
> > @@ -17,8 +17,9 @@ BUILD_DEPENDS= ${RUN_DEPENDS} \
> >
> > CONFIGURE_STYLE = modbuild
> >
> > -TEST_DEPENDS= devel/p5-Test-Pod \
> > - devel/p5-Test-LeakTrace \
> > - devel/p5-Try-Tiny
> > +TEST_DEPENDS= devel/p5-Test-LeakTrace \
> > + devel/p5-Try-Tiny
> > +
> > +MAKE_ENV += TEST_POD=Yes
> >
> > .include <bsd.port.mk>
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/www/p5-HTML-Tree/distinfo,v
> > retrieving revision 1.11
> > diff -u -p -u -p -r1.11 distinfo
> > --- distinfo 1 May 2017 19:54:18 -0000 1.11
> > +++ distinfo 8 Jan 2019 08:41:58 -0000
> > @@ -1,2 +1,2 @@
> > -SHA256 (HTML-Tree-5.06.tar.gz) =
> > nDbrGcvfmlkGyFiUjKUcNb11YfUswYxDKBrL5XMnU24= -SIZE
> > (HTML-Tree-5.06.tar.gz) = 150067 +SHA256 (HTML-Tree-5.07.tar.gz) =
> > 8DdNuEcxwgS4bB1bkJdf7w0wqGvZ3vkZND5VTjGp278= +SIZE
> > (HTML-Tree-5.07.tar.gz) = 150477
> >
> >
> >
> >
>
