On Tue, 08 Jan 2019 09:01:15 +0100
Solene Rapenne wrote:

> Charlene Wendling <juliana...@posteo.jp> wrote:
> > 
> > Here is a proposal for a new port, devel/p5-Mock-Config. It will be
> > needed to update devel/p5-Devel-CheckLib to 0.13 [1], which in turn
> > is needed to update databases/p5-DBD-mysql [2] to 4.049, the current
> > version of (4.042) we're shipping can't be built with Perl 5.28 [3]
> > (that's why i'm CC'ing you Giovanni).  
> > 
> > It has been made with portgen(1), i've just improved DESCR, and
> > added Pod testing. 'make test' passes, only the manifest test is
> > skipped, because it can only be run from a git checkout. 
> > 
> > Package infos: 
> > 
> > Comment:
> > temporarily set Config or XSConfig values
> > 
> > Description:
> > This module temporarily sets Config or XSConfig, as a workaround to
> > XSConfig being readonly. The importer works only dynamically, not
> > lexically yet.
> > 
> > WWW: http://search.cpan.org/dist/Mock-Config/
> > 
> > Any comments or feedback? 
> > 
> > Charlène. 
> > 
> > [1]
> > https://metacpan.org/source/MATTN/Devel-CheckLib-1.13/META.json#L29
> > [2] https://metacpan.org/changes/distribution/DBD-mysql#L34
> > [3]
> > https://github.com/perl5-dbi/DBD-mysql/commit/5480266b35f8dcf8f3fd6b303823158038cdcfd7
> 
> port looks fine except for the indent after PERMIT_PACKAGE_CDROM
> which is different than the indent before that line.
> 

Hi, 

Thanks for reviewing! I'm attaching a tarball with better indenting in
the Makefile. 

Charlène. 

Attachment: p5-Mock-Config.tar.gz
Description: Binary data

Reply via email to