On Sat, 5 Jan 2019 17:55:51 +0100
Charlene Wendling wrote:
> Hi ports,
>
> Here is an update for Crypt::OpenSSL::X509 that will fix the build
> with our future Perl 5.28.
>
> Upstream changes are mostly to fix compilation on various systems
> [1].
>
> What's new in the port:
>
> - Had to fix the Makefile.PL patch
> - Added ssl to WANTLIB because it was missing
> - Enabled Pod testing
>
> Testing:
>
> - 'make test' passes on amd64 and macppc (XS module)
> - There are 2 consumers, they pass without issues [2].
>
>
> Any comments/feedback?
>
> Charlène.
>
> [1]
> https://metacpan.org/source/JONASBN/Crypt-OpenSSL-X509-1.812/Changes
> [2] https://transfer.sh/NPsj3/p5-Crypt-OpenSSL-X509.tgz
>
>
Here is the diff with the fixed WANTLIB. Sorry for the noise.
Index: Makefile
===================================================================
RCS file: /cvs/ports/security/p5-Crypt-OpenSSL-X509/Makefile,v
retrieving revision 1.9
diff -u -p -u -p -r1.9 Makefile
--- Makefile 23 Sep 2017 10:51:07 -0000 1.9
+++ Makefile 5 Jan 2019 18:22:51 -0000
@@ -2,16 +2,17 @@
COMMENT = access OpenSSL's X509 API from Perl#'
-DISTNAME = Crypt-OpenSSL-X509-1.807
-REVISION = 0
+DISTNAME = Crypt-OpenSSL-X509-1.812
CATEGORIES = security
# Perl
PERMIT_PACKAGE_CDROM = Yes
-WANTLIB += c crypto perl
+WANTLIB += c crypto perl ssl
MODULES = cpan
+
+MAKE_ENV += TEST_POD=Yes
.include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/security/p5-Crypt-OpenSSL-X509/distinfo,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 distinfo
--- distinfo 30 Apr 2017 13:56:43 -0000 1.5
+++ distinfo 5 Jan 2019 18:22:51 -0000
@@ -1,2 +1,2 @@
-SHA256 (Crypt-OpenSSL-X509-1.807.tar.gz) =
Wse6PXSGOubPK4qN+RK+f3pTNwN7Za3sqA+SdL8Augw=
-SIZE (Crypt-OpenSSL-X509-1.807.tar.gz) = 45947
+SHA256 (Crypt-OpenSSL-X509-1.812.tar.gz) =
whKD0zrU6n/ECdtRWbfXpnkyW93yOP1Ap6385GioRlk=
+SIZE (Crypt-OpenSSL-X509-1.812.tar.gz) = 47890
Index: patches/patch-Makefile_PL
===================================================================
RCS file: /cvs/ports/security/p5-Crypt-OpenSSL-X509/patches/patch-Makefile_PL,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 patch-Makefile_PL
--- patches/patch-Makefile_PL 24 May 2017 00:59:48 -0000 1.1
+++ patches/patch-Makefile_PL 5 Jan 2019 18:22:51 -0000
@@ -3,12 +3,12 @@ $OpenBSD: patch-Makefile_PL,v 1.1 2017/0
Index: Makefile.PL
--- Makefile.PL.orig
+++ Makefile.PL
-@@ -22,7 +22,7 @@ requires_external_cc();
- } elsif ($Config::Config{myuname} =~ /sunos|solaris/i) {
- # Any SunStudio flags?
- } else {
-- cc_optimize_flags('-O2 -g -Wall -Werror');
-+ cc_optimize_flags('-O2 -g -Wall -Werror
-Wno-ignored-optimization-argument');
- }
+@@ -22,7 +22,7 @@ if ($Config::Config{myuname} =~ /darwin/i) {
+ } elsif ($Config::Config{myuname} =~ /sunos|solaris/i) {
+ # Any SunStudio flags?
+ } else {
+- cc_optimize_flags('-O2 -g -Wall -Werror');
++ cc_optimize_flags('-O2 -g -Wall -Werror
-Wno-ignored-optimization-argument');
+ }
auto_install();
