On Sun, Dec 30 2018, Rafael Sadowski <raf...@sizeofvoid.org> wrote:
> On Sat Dec 29, 2018 at 01:40:12PM +0100, Pascal Stumpf wrote:
>> On Sat, 29 Dec 2018 12:55:02 +0100, Rafael Sadowski wrote:

[...]

>> > Build and package fine with clang on amd64.
>> > 
>> > "CXX=g++ make" configure fine but fails at compile step (Of course,
>> > it's c++11) but there is no COMPILER var in Makefile.
>> > 
>> > $ CXX=eg++ make
>> > checking whether eg++ accepts -g... (cached) yes
>> > checking dependency style of eg++... none
>> > checking how to run the C++ preprocessor... /lib/cpp
>> > configure: error: in `/usr/ports/pobj/libupnpp-0.16.1/libupnpp-0.16.1':
>> > configure: error: C++ preprocessor "/lib/cpp" fails sanity check
>> > See `config.log' for more details
>> 
>> Works fine if you set both CXX=eg++ and CC=egcc.
>> 
>
> Maybe it's my problem but I'm still running in this issue with both CXX=eg++
> and CC=egcc. Could anybody else double check this?

I can successfully package with ports-gcc on amd64, using

  ''make clean repackage CC=egcc CXX=eg++''

I would not expect passing CC/CXX in the environment to work.

Regarding the port:
- please drop the LIB_DEPENDS on nghttp2, libupnpp doesn't directly link
  against it, the dep comes through libcurl.la.  libpunpp links against:
  LIBUPNPP_LIBS -lpthread  -pthread -L/usr/local/lib -lupnp -lthreadutil -lixml 
-L/usr/local/lib -lcurl  -lexpat
- please drop NO_TEST=Yes.  There are no tests but ''make test'' doesn't
  fail.

With those two points addressed, ok jca@ to import

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to