ti 1. tammik. 2019 klo 5.29 Klemens Nanni (k...@openbsd.org) kirjoitti: > > On Sun, Dec 30, 2018 at 11:18:32PM +0200, Hannu Vuolasaho wrote: > > svn has fixed those too... and man page PREFIX expansion is on TODO. > > So next release should be patchless. > Great! > > > There are also --symbols and --profile configure options. The > > debugging option is > > mainly used for portability check with std=c89. > Hm, CFLAGS is currently ignored completely and I missed this previously. > Passing it through CONFIGURE_ARGS will propagate DEBUG for us, so let's > use that. > > However, I need to remove the `--debug' flag, otherwise it overwrites > stuff again. Since the configure script is not a script but a binary > being compiled right before execution without proper usage, I'm > reluctant to look any further into this.
That's OK. Scconfig is designed to be simple and robust. It is totally different beast when compared to autotools or cmake. > Looks much better. I've made a few minor tweaks: > > * zap trailing tab in WANTLIB line, sort libs > * add some newlines and slightly reorder MOD* variables for readability > * pass CFLAGS, drop `--debug' in CONFIGURE_ARGS > * break LIB_DEPENDS into one port per line > * quote variables > * moved targets (pre-configure) to the end as usual > * zap useless NO_TEST comment > > What do you think? > > Feedback? OK to import? Thank you. I've learned a lot about ports' Makefile system. The revision tag points to Makefile.template still but otherwise OK for me. Best regards, Hannu Vuolasaho
