On Sat, Dec 08, 2018 at 01:52:26PM +0200, Timo Myyrä wrote: > > > Also, it seems that the two patches are unnecessary? And that we can > > also remove the following line from the port Makefile? > > > > CONFIGURE_ARGS += -DFLUIDSYNTHLIB1="libfluidsynth.so" > > > > Lastly, I wonder if it wouldn't be better to link against fluidsynth, > > add audio/generaluser-gs-soundfont in RUN_DEPENDS, and finally patch > > src/gameconfigfile.cpp so it automatically finds the SoundFont banks. > > This would result in a fully functional port playing music out of the > > box, without requiring any manual fiddling. Any thoughts on this? > > > > Yeah, the patches are only there to keep fluidsynth as optional dependency.
When testing, it worked without patches both when linking against fluidsynth and when keeping it as an optional dependency. > The music works without fluidsynth, fluidsynth sounds a bit better. If we add > fluidsynth as mandatory dependency, how about timidity? Thats why I added > only those that are strictly needed to run the game as dependency. The game > could probably be patched so that it only shows the available sound / music > backends in the menus. I see, I was indeed able to get music playing without fluidsynth by selecting the OPL synth emulation, it wasn't enabled by default. I don't think patching the game to only show available backends would be worth it, but if it's not too much work, having OPL synth emulation be the default would be nice.
