On 2018/09/15 09:37, Thomas Frohwein wrote: > On Wed, Aug 29, 2018 at 07:35:51PM -0700, Thomas Frohwein wrote: > > Hi, > > > > This is a new port of WeiDU, a tool to manage modifications for Infinity > > Engine > > games which for OpenBSD is essentially all that run with the gemrb port. > > Main > > use case is likely installation of the widescreen mod for those games with > > weinstill. This is outlined as an example in the README. It also allows > > patching > > these games with weidu. > > > > This port has been a little more on the complicated side: It requires > > elkhound > > for building. elkhound doesn't seem to have a lot of use cases from what > > I've > > heard and upstream has been pretty much inactive for about 10 years. > > Therefore, > > I added elkhound as a subdir in the tarball that creates the binary just for > > building weidu, as opposed to creating a separate elkhound port. Then that > > binary is used for the build process, but not installed. > > > > Compilation: > > - contains do-build which just builds elkhound first and weidu second. > > - elkhound has a lot of hardcoded g++. Changed to c++ with sed. Also needs > > cc/c++ hardcoded in a few Makefile.in > > - Several hardcoded -O2 replaced with CFLAGS in elkhound. Not sure if this > > may > > have been a waste of time given that it's only used during the build... > > > > Tests and functionality: > > - Tested all 3 binaries. > > - weidu tested to successfully decompile a .dlg file and compile a .d file > > - weinstall tested with installing widescreen mod with Baldur's Gate 1&2 and > > Planescape: Torment > > - Comes with a binary 'tolower' that converts all filenames in the directory > > to lower case recursively. > > > > Package and hosting: > > - elkhound is not installed (only needed for building). > > - Includes a README with installation of widescreen mod as example (this > > will > > most likely be the most common use case) > > - Can someone host the tarball for me again? > > > > ok? > > ping - No one interested in running their Baldur's Gate or Planescape Torment > in > HD?
It needs updating for the PKGSTEM change for pkg-readmes, and (in readme step 1) it's generally best to talk about packages rather than ports because that's what we prefer people to use. It probably doesn't matter as elkhound is not that likely to change anyway it seems, but I'd probably rename the directory for that to something without a date, to avoid future changes to Makefile targets and especially patch filenames. There are some bad "mv" commands (see paste below, you can add "ECHOSTYLE_SCOTT=1" to MAKE_FLAGS to see the actual command lines for these), they don't seem to break the build but probably worth a look to see what's up? (Also CC/CXX settings aren't honoured in various parts of the build but are probably going to be annoying enough to fix that we might as well just rely on the less clean symlinks in WRKDIR/bin..) BUILD FINISHED gmake[1]: Leaving directory '/usr/obj/ports/weidu-246.00/weidu-v246.00/elkhound-src-2018-05-12/elkhound' cd /usr/obj/ports/weidu-246.00/weidu-v246.00 && env -i CC="cc" PORTSDIR="/usr/ports" LIBTOOL="/usr/bin/libtool" CCAC HE_DIR=/usr/obj/ports/.ccache PATH='/usr/obj/ports/weidu-246.00/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11R6/bin' PREFIX='/usr/local' LOCALBASE='/usr/local' X11BASE='/usr/X11R6' CFLAGS='-O2 -pipe' TRUEPREFIX='/usr/loc al' DESTDIR='' HOME='/weidu-246.00_writes_to_HOME' COMPILER_VERSION=clang PICFLAG="-fpic" BINGRP=bin BINOWN=root BI NMODE=755 NONBINMODE=644 DIRMODE=755 INSTALL_COPY=-c INSTALL_STRIP=-s MANGRP=bin MANOWN=root MANMODE=644 BSD_INSTALL_PROGRAM="/usr/obj/ports/weidu-246.00/bin/install -c -s -m 755" BSD_INSTALL_SCRIPT="/usr/obj/ports/weidu-246.00/bin/ install -c -m 755" BSD_INSTALL_DATA="/usr/obj/ports/weidu-246.00/bin/install -c -m 644" BSD_INSTALL_MAN="/usr/obj/po rts/weidu-246.00/bin/install -c -m 644" BSD_INSTALL_PROGRAM_DIR="/usr/obj/ports/weidu-246.00/bin/install -d -m 755" BSD_INSTALL_SCRIPT_DIR="/usr/obj/ports/weidu-246.00/bin/install -d -m 755" BSD_INSTALL_DATA_DIR="/usr/obj/ports/weidu -246.00/bin/install -d -m 755" BSD_INSTALL_MAN_DIR="/usr/obj/ports/weidu-246.00/bin/install -d -m 755" gmake V=1 ECHO STYLE_SCOTT=1 LIBTOOL="/usr/bin/libtool" SHARED_LIBS_LOG=/usr/obj/ports/weidu-246.00/weidu-v246.00/shared_libs.log - f Makefile weidu weinstall tolower /usr/local/bin/ocamlyacc src/toldparser.mly 17 shift/reduce conflicts. mv -f src/toldparser.ml src/toldparser.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory ocaml str.cma unix.cma -w p scripts/make_gr.ml File "./scripts/make_gr.ml", line 2, characters 13-29: Warning 3: deprecated: String.uppercase Use String.uppercase_ascii instead. elkhound-src-2018-05-12/elkhound/elkhound -ocaml src/trealparserin.gr 8 shift/reduce conflicts mv -f src/trealparserin.ml src/trealparserin.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory /usr/local/bin/ocamlyacc src/dparser.mly 1 reduce/reduce conflict. mv -f src/dparser.ml src/dparser.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory /usr/local/bin/ocamlyacc src/bafparser.mly mv -f src/bafparser.ml src/bafparser.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory /usr/local/bin/ocamlyacc src/refactordparser.mly mv -f src/refactordparser.ml src/refactordparser.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory /usr/local/bin/ocamlyacc src/refactorbafparser.mly mv -f src/refactorbafparser.ml src/refactorbafparser.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory /usr/local/bin/ocamlyacc src/bcsparser.mly 1 shift/reduce conflict. mv -f src/bcsparser.ml src/bcsparser.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory /usr/local/bin/ocamlyacc src/idsparser.mly 3 shift/reduce conflicts. mv -f src/idsparser.ml src/idsparser.mli obj/x86_LINUX usage: mv [-fiv] source target mv [-fiv] source ... directory /usr/local/bin/ocamldep -native -I obj/x86_LINUX -I src -I zlib -I glob -I xdiff -I elkhound -I batteries-lite batteri es-lite/batList.mli /bin/sh: cannot create obj/.depend/batList.di: No such file or directory Bad -I option: obj/x86_LINUX: No such file or directory /usr/local/bin/ocamldep -native -I obj/x86_LINUX -I src -I zlib -I glob -I xdiff -I elkhound -I batteries-lite src/tol ower.ml /usr/local/bin/ocamldep -native -I obj/x86_LINUX -I src -I zlib -I glob -I xdiff -I elkhound -I batteries-lite src/wei nstall.ml /usr/local/bin/ocamldep -native -I obj/x86_LINUX -I src -I zlib -I glob -I xdiff -I elkhound -I batteries-lite src/mya rg.ml