On Sat, Oct 20, 2018 at 01:00:12PM +0200, Jeremie Courreges-Anglas wrote: > On Thu, Oct 18 2018, Marc Espie <es...@nerim.net> wrote: > > [...] > > > armadillo is a C++ wrapper around lapack/blas linear algebra libraries, > > a required dependency of mlpack. > > > > Armadillo is a linear algebra library (matrix maths) for the C++ language, > > aiming towards a good balance between speed and ease of use. > > > > Provides high-level syntax and functionality deliberately similar to Matlab > > > > > > Attached is a tarball for math/mlpack and math/armadillo (extract under > > ports) > > > > I haven't checked that it builds under anything but amd64, though it should > > with a proper C++ compiler (hence the compiler annotations). > > Regarding armadillo, > > - could you please follow the usual layout of Makefile.template, and use > tabs for alignement? I find this Makefile hard to review, especially > with the location of DISTNAME...
Can do for armadillo mlpack is somewhat more annoying, and I've reviewed Makefile.template recently. Some of the order choices don't make *any* sense to me. Things have been added in an order that doesn't match any sane process. (for instance, fixing shared library versions and adding WANTLIB often happen fairly late) > - CONFIGURE_STYLE is not needed I prefer to stay explicit on that one. The .if empty() tests will trigger in a module dependent order if you have several modules (case in point: mlpack has cmake and python as dependencies. It's a case of too much magic in my opinion... > - cmake says > > -- Checking for module 'hdf5' > -- > -- HDF5_FOUND = > > so might pick up math/hdf5 if present (you already noticed, it seems) > It also looks for something called "superlu" but we have no port for > it (yet). Good catch. > - does not build with base-gcc but I see no compiler annotations. > This needs COMPILER = base-clang ports-gcc. Likewise. I remembered it for mlpack, but forgot armadillo.
