On Mon, 15 Oct 2018 12:54:33 -0700, "Heppler, J. Scott" <shep...@centurylink.net> wrote:
> I have been working on porting jgmenu which provides menu generation > for openbox, i3, dwm and other WM's. Jgmenu can source menu > generation from 4 different sources: > 1) Openbox menu.xml > 2) x11/menu-cache > 3) xdg > 4) pmenu > > The pmenu option is python3 code that has been embedded in the > upstream source. Upstream notes on python: > https://github.com/johanmalm/jgmenu/blob/master/docs/notes_on_python > > Upstream has been helpful and since the 1.3 tag has changed the code > base to accommodate openbsd (use setitimer() instead of timer_*). > > I am running a jgmenu -master pull spoofed as v1.4 in amd64_current > using x11/menu-cache in openbox. I had both python2(default) and > python3 when I built the port without any reference to python in the > Makefile. As long as the pmenu option is not used, it runs fine > without python. > > My question is specifying python3 in WANT_LIBS, BUILD_DEPENDS, > RUN_DEPENDS. Only when using pmenu is python3 needed for any of > these. Still the port should be fully functional. Does it need to be > specified in WANT_, BUILD_ and RUN_? > > What I have so far: > > # $OpenBSD: Makefile.template,v 1.78 2018/07/09 15:00:06 jca Exp $ > > COMMENT = freedesktop-complaint menu for openbox and tint2 probably a typo here ;) > V = master > CATEGORIES = x11 > DISTNAME = jgmenu-${V} > PKGNAME = jgmenu-1.4 > HOMEPAGE = https://github.com/johanmalm/jgmenu > GH_ACCOUNT = johanmalm > GH_PROJECT = jgmenu > GH_COMMIT = 5ee0b7e21715ba36690606db27f6dd85cd3ee0fc > WRKDIST = > ${WRKDIR}/jgmenu-5ee0b7e21715ba36690606db27f6dd85cd3ee0fc > > # GPLv2 only > PERMIT_PACKAGE_CDROM = Yes > > #MASTER_SITES = https://github.com/johanmalm/jgmenu/archive/v${V}/ > > WANTLIB += X11 Xrandr c m pthread z > WANTLIB += cairo gdk_pixbuf-2.0 gio-2.0 glib-2.0 gobject-2.0 > iconv WANTLIB += intl lzma menu-cache pango-1.0 pangocairo-1.0 > png WANTLIB += python${MODPY_DEFAULT_VERSION_3} rsvg-2 xml2 FWIW the module defines it as MODPY_WANTLIB = python${MODPY_VERSION}${MODPY_LIB_SUFFIX} > BUILD_DEPENDS = x11/menu-cache > > LIB_DEPENDS = devel/pango \ > x11/gnome/librsvg \ > x11/menu-cache > > MODULES = lang/python \ > x11/gnome > MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3} > MODGNOME_TOOLS = desktop-file-utils \ > gtk-update-icon-cache > > USE_GMAKE = Yes > > RUN_DEPENDS = lang/python/${MODPY_DEFAULT_VERSION_3} The module lang/python defines already the rdep. What you want is MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3} If you have a dep on a python lib, you need to suffix it with ${MODPY_FLAVOR}. Feel free to read port-modules(5) and lang/python/python.port.mk for more information. Does it help? Cheers, Daniel
