On 09/25/18 21:00, Brian Callahan wrote:
On 09/19/18 13:04, Stuart Henderson wrote:
On 2018/09/11 10:22, Stuart Henderson wrote:
On 2018/09/10 18:13, Brian Callahan wrote:
Sorry for the noise--meant to send the diff version of this.
I think that makes sense for now and doesn't change anything for the
default case so doesn't need a bulk. OK sthen@.
(Later I think it would be better to move setting CMAKE_MAKE_PROGRAM
down to the "either ninja or samurai" section, but that should go
through bulk build first.)
BTW bulk results are in. Most ninja users are OK with samurai except
for these.
First block are all "multiple rules generate X" where X is the
file/target mentioned:
devel/doxygen 'generated_src/configvalues.h'
devel/doxygen-gui 'generated_src/configvalues.h'
editors/kile-kde4 'doc/index.cache.bz2'
graphics/digikam-kde4
'/usr/obj/ports/digikam-4.13.0/digikam-4.13.0/core/cmake/templates/Info.plist.cmake.in'
graphics/krita
'cmake_object_order_depends_target_KisMaskGeneratorBenchmark'
net/libproxy 'test'
x11/kde4/pim 'kleopatra/libkleopatraclient/core/moc_command_p.cpp'
x11/kde4/pimlibs
'/usr/obj/ports/kdepimlibs-4.14.10/kdepimlibs-4.14.10/akonadi/contact/actions/contactactionssettings.kcfg.cmake'
x11/kde4/workspace
'/usr/obj/ports/kde-workspace-4.11.21/kde-workspace-4.11.21/kinfocenter/Modules/base/config-infocenter.h.cmake'
For these, ninja still notices this multiple rules issue but treats it
as a warning. Samurai treats it as an error. This diff should clear
all these up. Can send this upstream too.
Ping. Thoughts? Not a pressing issue for 6.4, of course, but perhaps
worth the movement on it now.
~Brian
Also:
www/webkitgtk4 ImportError: No module named jsmin
Not sure about this one...
~Brian
Hard to say if it changes timings at all, but as a bulk builder I find
diffable logs and fewer transient errors due to random build ordering
quite appealing ...
