On 2018/09/26 16:53, Solene Rapenne wrote:
> Denis Fondras <open...@ledeuns.net> wrote:
> > ssss is an implementation of Shamir's Secret Sharing Scheme. The program 
> > suite
> > does both: the generation of shares for a known secret, and the 
> > reconstruction
> > of a secret using user-provided shares.
> > 
> > http://point-at-infinity.org/ssss/
> 
> hello
> 
> portcheck reports hardcoded paths in Makefile and port-lib-depend-check 
> reports
> missing c in WANTLIB
> 
> here is a diff to your makefile to fix it
> 
> ok solene@ with the diff applied
> 
> thank you for porting this, seems very useful :)
> 
> 
> --- Makefile.orig       Wed Sep 26 16:50:25 2018
> +++ Makefile    Wed Sep 26 16:51:01 2018
> @@ -14,10 +14,10 @@
> 
>  MASTER_SITES=  http://point-at-infinity.org/ssss/
> 
> -WANTLIB +=     gmp
> +WANTLIB +=     c gmp
>  LIB_DEPENDS =  devel/gmp
> 
> -MAKE_FLAGS=     CC="${CC} -I/usr/local/include -L/usr/local/lib"
> +MAKE_FLAGS=     CC="${CC} -I${LOCALBASE}/include -L${LOCALBASE}/lib"
> 
>  ALL_TARGET=    ssss-split ssss-combine
> 
> 

Please zap the trailing . in COMMENT, and reorder lines according to
Makefile.template.

Also it needs to be taught to honour CFLAGS, currently it hardcodes -O2,
and avoid stripping if DEBUG is set.

Reply via email to