On 2018/09/20 16:35, Joel Carnat wrote: > Le 20/09/2018 15:54, Stuart Henderson a écrit : > > On 2018/09/20 13:58, Joel Carnat wrote: > > > Hi, > > > > > > By default, syslog-ng uses /var/run/syslog.pid: > > > # grep pid /etc/rc.d/syslog_ng > > > daemon_flags="-p /var/run/syslog.pid" > > > > > > This interferes (during newsyslog) with syslogd which is also using > > > this pid > > > file. > > > > > > One can use `rcctl set syslog_ng flags -p /var/run/syslog-ng.pid` to > > > solve > > > this. > > > But wouldn't it be better to set another default pid file in > > > /etc/rc.d/syslog_ng ? > > > > > > Best regards. > > > > > > > I think that might have originally been intentional, to make things > > easier for people using syslog-ng in place of syslogd. But that can't > > actually work with the syslog-ng version currently in ports (in > > OpenBSD 5.6+ the new fd-safe sendsyslog interface is used, syslog-ng > > didn't start supporting this until 3.14.1, ports has 3.12.1), so it > > probably does make sense to change this. > > > > Does it use a sane pid filename by default? If so then it might be > > best to leave the -p flag out from the rc script completely. > > According to the Makefile: "--with-pidfile-dir=/var/run". > I've commented both daemon_flags and syslog_ng_flags and restarted > syslog-ng. > A /var/run/syslog-ng.pid file was created referencing the correct PID. > > So I'd say removing the daemon_flags line from rc.d/syslog_ng would be > enough. >
Makes sense. Steven, is this OK with you? Index: Makefile =================================================================== RCS file: /cvs/ports/sysutils/syslog-ng/Makefile,v retrieving revision 1.63 diff -u -p -r1.63 Makefile --- Makefile 12 Feb 2018 10:03:49 -0000 1.63 +++ Makefile 20 Sep 2018 15:28:06 -0000 @@ -6,7 +6,7 @@ V = 3.12.1 REL = 3.12 DISTNAME = syslog-ng-$V CATEGORIES = sysutils -REVISION = 4 +REVISION = 5 MAINTAINER = Steven Mestdagh <[email protected]> Index: pkg/syslog_ng.rc =================================================================== RCS file: /cvs/ports/sysutils/syslog-ng/pkg/syslog_ng.rc,v retrieving revision 1.7 diff -u -p -r1.7 syslog_ng.rc --- pkg/syslog_ng.rc 11 Jan 2018 19:27:11 -0000 1.7 +++ pkg/syslog_ng.rc 20 Sep 2018 15:28:06 -0000 @@ -3,7 +3,6 @@ # $OpenBSD: syslog_ng.rc,v 1.7 2018/01/11 19:27:11 rpe Exp $ daemon="${TRUEPREFIX}/sbin/syslog-ng" -daemon_flags="-p /var/run/syslog.pid" . /etc/rc.d/rc.subr
