Hi Greg --
On 09/01/18 06:41, Greg Baker wrote:
Hello ports@
This is the second dependency in the long chain of dependencies for hledger (a
text-based
accounting system useful for certain kinds of small businesses).
The ports entry itself is a Haskell library for doing diffs.
Looking for someone to review this (and possibly hs-Decimal, my submission from
last week)
with a view to merging it.
Sorry for taking so long to review.
Note that I'm not a Haskell person, but from a porting perspective, some
notes:
1. You need an RCS ID line as the first line of the port Makefile.
# $OpenBSD$
is sufficient for that.
2. No REVISION line for new ports, that's for something else.
3. We tend to just use "BSD" for the license marker for all the BSD
licenses.
4. You only need PERMIT_PACKAGE_CDROM=Yes the other 2 are implied from that.
5. I got "Not found: /usr/local/lib/ghc/Diff-0.3.4/unregister.sh (in
/usr/ports/mystuff/devel/hs-Diff/pkg/PLIST)" when running `make
update-plist' and the PLIST did in fact change, just one line though:
"-lib/ghc/${DISTNAME}/unregister.sh" I don't know what it means that it
removed that unregister line so hopefully a Haskell person comes around
and answer that.
~Brian
