On 09/07/18 16:14, Brian Callahan wrote:
On 09/07/18 14:22, David CARLIER wrote:
Thanks ... here a newer version.
Can you please stop sending diffs that you clearly haven't tested?
It's a waste of time. You're clearly just guessing at these updates
which you would immediately know if you bothered to try to actually
build the stuff. `make port-lib-depends-check' unsurprisingly
resynched the PLIST when I ran it, and you still have
`make update-plist' obviously, not `make port-lib-depends-check' :)
something in FILESDIR that we're not installing any more so it has to go.
Attached is a real diff that actually works and that I actually
tested. It would have taken you, what, 10 minutes to do the work
instead of subjecting someone (me and solene@, in this case) to having
to do more work to figure out what you missed, now what, 3 or 4
different diffs you've sent, all broken? I'm going to start sending
all your emails to /dev/null, because this is not the first time
you've done this.
~Brian
On Fri, 7 Sep 2018 at 18:01, Brian Callahan <bcal...@devio.us> wrote:
On 09/07/18 11:37, Solene Rapenne wrote:
David CARLIER <devne...@gmail.com> wrote:
Here attached a slightly different version of the port after Solene
had kindly tested on her side, helped me to pinpoint the cause.
If @thfr and/or @bcallah could give a try, would be great and would
push upstream the fix if confirmed.
Thanks.
The patch on Makefile fails
|Index: Makefile
|===================================================================
|RCS file: /cvs/ports/games/barony/Makefile,v
|retrieving revision 1.2
|diff -u -p -r1.2 Makefile
|--- Makefile 5 May 2018 08:23:17 -0000 1.2
|+++ Makefile 3 Sep 2018 21:58:31 -0000
--------------------------
Patching file Makefile using Plan A...
Hunk #1 succeeded at 1 with fuzz 1.
Hunk #2 failed at 8.
Hunk #3 succeeded at 40.
1 out of 3 hunks failed
Additionally, this is missing some LDEPS, at least one on PhysFS.
CMake Error at
/usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:137
(message):
Could NOT find PhysFS (missing: PHYSFS_LIBRARY PHYSFS_INCLUDE_DIR)
Call Stack (most recent call first):
/usr/local/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:378
(_FPHSA_FAILURE_MESSAGE)
cmake/Modules/FindPhysFS.cmake:47
(FIND_PACKAGE_HANDLE_STANDARD_ARGS)
CMakeLists.txt:150 (find_package)
-- Configuring incomplete, errors occurred!
~Brian
