On 2018/09/07 19:13, Björn Ketelaars wrote: > On Fri 07/09/2018 14:40, Stuart Henderson wrote: > > On 2018/09/05 14:51, Björn Ketelaars wrote: > > > A new version of git-cola is available fixing several usability issues, > > > and adding some new features. Changelog can be found at > > > https://github.com/git-cola/git-cola/blob/64f94b51573653a2f31db24fdf2239387bce2b2a/share/doc/git-cola/relnotes.rst > > > > > > 'make test' runs successfully, and I've been running this version for > > > the last couple of days on amd64 without encountering a regression. > > > > > > Before committing the diff below: any users who like to do some > > > additional testing? > > > > OK, though in the interest of reproducibility (git-cola uses py-qt5 if > > present, then py-qt4, then pyside, in that order) I wonder if it's maybe > > worth switching the dep to py-qt5? Or making it an "either/or"? > > > > git-cola has xxdiff as RDEP, which in turn depends on QT4. Changing > git-cola to py-qt5 increases the number of dependencies significantly, > which imho does not make sense as it does not solve a problem, or add > a nice to have feature. > I prefer not switching to py-qt5. > > OK?
Fair enough, my OK still stands.
