On 08/08/18 07:51, Charlène wrote:
On Wed, 8 Aug 2018 09:17:52 +0100
Stuart Henderson wrote:
On 2018/08/07 20:27, Charlène wrote:
On Mon, 6 Aug 2018 10:52:23 +0200
Charlène wrote:
Hi,
I'm currently working on an update for audio/abcde, that requires
this update and a new port (audio/p5-MusicBrainz-DiscID).
Abcde wants WebService::MusicBrainz v1.0.4, the latest release as
i'm writing this.
Many things changed, i'm quoting upstream:
« Version 1.0 and future releases are not backward compatible with
pre-1.0 releases. This is a complete re-write using version 2.0
of the MusicBrainz API and Mojolicious. »
So i've checked with sqlports, no other ports than the future
updated audio/abcde depends on this port.
I'm also joining a very basic script, if you want to test the
module.
Comments and OK are welcome!
Charlène.
Hi,
I'm proposing myself as MAINTAINER for this port, so i'm joining a
new diff.
Charlène.
+LIB_DEPENDS= www/p5-Mojo>=7.13
LIB_DEPENDS is the wrong thing for Perl modules, they are RUN_DEPENDS.
LIB_DEPENDS without an associated WANTLIB is always wrong.
Hi Stuart,
Thanks for reviewing, i'm taking note of it and changed accordingly,
also removed a spacing inconsistency on MAINTAINER line.
I've retested those changes, it builds and runs fine on my amd64
machine.
Charlène.
Some of the tests fail here though I'm not sure how much that matters.
Stuart, you can go commit the update if you want. ok for me.
~Brian
