I think with this it would be safer to bump librelp major, it might not be strictly needed, but at least one exported function has a change in arguments (relpTcpLstnInit) and there's a new variable in the middle of struct relpSess_s, possibly these are internal-only but unless we're backporting to -stable it's often simpler to just bump than spend time figuring it out.
So, OK with SHARED_LIBS += relp 2.0 # 4.0 On 2018/08/13 23:18, Remi Locherer wrote: > ping > > On Sun, Aug 05, 2018 at 03:30:28PM +0200, Remi Locherer wrote: > > Hi, > > > > this updates librelp to version 1.2.16. > > > > Some memory leaks have been fixed and the API extended. > > The changelog is here: https://www.rsyslog.com/librelp-1-2-16/ > > > > 3 of the tests fail: 2 because of expired test certs and 1 because the test > > framework tries to use valgrind even if it's not installed. It looks like > > these failures will be fixed in 1.2.17 once released. > > > > I tested it on i386 and amd64 with rsyslogd 8.33.1 from ports. > > > > OK? > > > > Remi > > > > > > Index: Makefile > > =================================================================== > > RCS file: /cvs/ports/sysutils/librelp/Makefile,v > > retrieving revision 1.12 > > diff -u -p -r1.12 Makefile > > --- Makefile 2 Apr 2018 16:57:56 -0000 1.12 > > +++ Makefile 5 Aug 2018 13:27:22 -0000 > > @@ -2,13 +2,13 @@ > > > > COMMENT = reliable event logging protocol library > > > > -DISTNAME = librelp-1.2.15 > > +DISTNAME = librelp-1.2.16 > > > > -SHARED_LIBS += relp 1.1 # 3.0 > > +SHARED_LIBS += relp 1.2 # 4.0 > > > > CATEGORIES = sysutils > > > > -HOMEPAGE = http://www.librelp.com/ > > +HOMEPAGE = https://www.rsyslog.com/librelp/ > > > > MAINTAINER = Remi Locherer <r...@openbsd.org> > > > > @@ -22,8 +22,14 @@ MASTER_SITES = http://download.rsyslog. > > > > LIB_DEPENDS = security/gnutls > > > > +TEST_DEPENDS = shells/bash \ > > + ${LIB_DEPENDS} > > + > > SEPARATE_BUILD = Yes > > > > CONFIGURE_STYLE = gnu > > + > > +pre-test: > > + sed -i s,#!/bin/bash,#!${LOCALBASE}/bin/bash, ${WRKSRC}/tests/*.sh > > > > .include <bsd.port.mk> > > Index: distinfo > > =================================================================== > > RCS file: /cvs/ports/sysutils/librelp/distinfo,v > > retrieving revision 1.5 > > diff -u -p -r1.5 distinfo > > --- distinfo 2 Apr 2018 16:57:56 -0000 1.5 > > +++ distinfo 4 Aug 2018 11:41:31 -0000 > > @@ -1,2 +1,2 @@ > > -SHA256 (librelp-1.2.15.tar.gz) = > > qTGDLZBWZg/u521SGVsh1OngbV7I6Wsmr0TpmFKdqZk= > > -SIZE (librelp-1.2.15.tar.gz) = 440273 > > +SHA256 (librelp-1.2.16.tar.gz) = > > DCNd0qAQYK1eZEOIebMa5k52QNDiYqoaKHot2bxg/VM= > > +SIZE (librelp-1.2.16.tar.gz) = 474456 >
