Hi Alessandro --
On 08/04/18 02:39, Alessandro DE LAURENZIS wrote:
Ciao Brian,
On 08/03/18 21:07, Brian Callahan wrote:
[...]
I used the following comment line, detailing the tools/libs present
in /src and the corresponding licenses:
# MIT (abc, minisat), BSD (bzlib, CUDD), zlib
I'm not sure these are entirely correct? bzlib should be listed under
the zlib license, no? There might be other license marker tweaks
needed so please double check.
Let me explain what I did in order to collect the license info:
[... snip ...]
$ pwd
/usr/ports/pobj/abc-1.01.20180722/abc-ae6716b064c842f45109a88e84dca71fe4cc311f
$ find . -name "*LICENSE*" -o -name "*license*" -o -name "*copy*" -o
-name "*COPY*"
./copyright.txt
./src/bdd/cudd/license
./src/misc/bzlib/LICENSE
./src/misc/zlib/license
./src/sat/bsat/license
./src/sat/bsat2/LICENSE
./src/sat/satoko/LICENSE
./src/sat/xsat/license
[... snip ...]
So, as Stuart noticed, on top of abc itself (released under the MIT
license), there are:
- local copies of CUDD, bzlib and zlib;
- a slightly modified version of MiniSat (bsat, bsat2, released under
the same MIT license);
- xSAT, based on bsat and released under the MIT license;
-satoko, released under the 2-clause BSD license.
CUDD uses the 3-clause BSD license, so I merged it with MiniSat/xSAT
under a generic BSD tag.
bzlib is part of bzip2 and is released under a BSD-style license (not
the zlib one as you guessed).
I did not guess. I read ${WRKSRC}/src/misc/bzlib/LICENSE. Clauses 2 and
3 are identical to the zlib license. But our ports tree also uses a BSD
marker for bzip2 so it's not worth quibbling over. Perhaps "BSD-style"
if we want to be extremely precise but I don't think it matters.
zlib has its own license.
I tweaked a bit the license marker line, hoping it's more complete now:
# MIT (abc, MiniSat, xSAT), BSD (bzlib, CUDD, satoko), zlib
[...]>> do-install target required a tweak in order to take the
executable
from ${WRKDIR}/build-${MACHINE_ARCH}. Should I set SEPARATE_BUILD too?
cmake sets SEPARATE_BUILD for you. Use WRKBUILD instead of that
WRKDIR/build-MACHINE_ARCH thing.
Fixed.
New tarball attached.
There appear to be stray lines in pkg/PLIST:
man/ja_JP.EUC/cat3f/
man/ja_JP.EUC/man3f/
man/ja_JP.EUC/man3p/
But now that I think about it, I've heard reports from other users about
`make plist` writing out these lines in other ports too so I'm wondering
if something changed recently... but it's late here I'll track it down
in the morning if no one else beats me to it.
~Brian
