- There are various hardcoded /usr/local instances, where these refer
to "files from another port" they should be ${LOCALBASE} and use
SUBST_CMD or similar, where they refer to "location this port is
installing to" they should use ${PREFIX}.
- "WANTLIB += python2.7" should use ${MODPY_WANTLIB}
- "EXTRACT_SUFX = .tar.gz" is already the default and doesn't need setting
- pkg/DESCR could do with slight rework, maybe something like
-sK1 is an open source vector graphics editor First of all sK1 is
-oriented for prepress industry, therefore works with CMYK colorspace
-and produces CMYK-based PDF and postscript output.
+sK1 is an open source vector graphics editor. Being primarily aimed at
+the prepress industry, it works with the CMYK colorspace and produces
+CMYK-based PDF and postscript output.
With those things fixed it's ok with me.
>
> 2018-07-14 18:19 GMT-03:00 Elias M. Mariani <marianiel...@gmail.com>:
> > I don't see what it is that I'm missing, could you clarify?
> > I added myself as maintainer in this port as well changed the comment
> > to "GPLv3+", that was the issue ?
> >
> > 2018-07-14 15:49 GMT-03:00 Brian Callahan <bcal...@devio.us>:
> >>
> >> On 07/14/18 14:11, Elias M. Mariani wrote:
> >>>
> >>> Ping and a small modification.
> >>
> >>
> >> You have not addressed previous feedback with this version.
> >>
> >> ~Brian
> >>
> >>
> >>> Cheers.
> >>> Elias.
> >>>
> >>> 2018-06-30 19:51 GMT-03:00 Elias M. Mariani <marianiel...@gmail.com>:
> >>>>
> >>>> Sorry for spamming but I added some things:
> >>>> - Change @exec to @tags.
> >>>>
> >>>> Cheers.
> >>>> Elias.
> >>>>
> >>>> 2018-06-22 2:25 GMT-03:00 Kirill Bychkov <ki...@linklevel.net>:
> >>>>>
> >>>>> On Mon, June 18, 2018 21:26, Elias M. Mariani wrote:
> >>>>>>
> >>>>>> Well, I dont know what to tell you...
> >>>>>> The version that I commited is fully functional as I understand and is
> >>>>>> already updated.
> >>>>>> You should move your stuff to this repository:
> >>>>>> https://github.com/jasperla/openbsd-wip
> >>>>>> There is where we look before start porting something new, but leave
> >>>>>> sk1 as presented here.
> >>>>>
> >>>>> In my opinion it wasn't ready enough to be moved to openbsd-wip.
> >>>>> openbsd-wip is not a graveyard.
> >>>>>
> >>>>>> Cheers.
> >>>>>> Elias.
> >>>>>>
> >>>>>> 2018-06-16 17:58 GMT-03:00 Kirill Bychkov <ki...@linklevel.net>:
> >>>>>>>
> >>>>>>> On Thu, June 14, 2018 09:41, Elias M. Mariani wrote:
> >>>>>>>>
> >>>>>>>> Find attached the new version with just missing whitespaces between
> >>>>>>>> the variables of the Makefile.
> >>>>>>>> Good for a weekly ping. :D
> >>>>>>>>
> >>>>>>>> Cheers.
> >>>>>>>> Elias.
> >>>>>>>
> >>>>>>> Hi.
> >>>>>>> I have this port sitting in mystuff for a long time. It requires
> >>>>>>> lcms with pyton bindings. I have a patch for lcms (not lcms2). IIRC
> >>>>>>> it was done for some previous version of sk1.
> >>>>>>> http://cvs.linklevel.net/index.cgi/ports/graphics/sk1project/
> >>>>>>>
> >>>>>>>> 2018-06-07 15:32 GMT-03:00 Elias M. Mariani <marianiel...@gmail.com>:
> >>>>>>>>>
> >>>>>>>>> sK1 is an open source vector graphics editor.
> >>>>>>>>> First of all sK1 is oriented for prepress industry, therefore works
> >>>>>>>>> with CMYK colorspace and produces CMYK-based PDF and postscript
> >>>>>>>>> output.
> >>>>>>>>>
> >>>>>>>>> I use it myself to create vector graphics and exporting them to SVG.
> >>>>>>>>> Pretty cool.
> >>>>>>>>>
> >>>>>>>>> Tested by me, no errors found.
> >>>>>>>>> Looking for tester/OK/commit
> >>>>>>>>>
> >>>>>>>>> Cheers.
> >>>>>>>>> Elias.
> >>>>>>>
> >>>>>>>
> >>>>>
> >>
