On 2018/05/27 22:45, Martijn van Duren wrote: > To me it appears that we could remove patch-Zend_zend_alloc_c. > The code behind it is hidden behind ZEND_MM_HEAP_PROTECTION and > ZEND_MM_COOKIES, which are both defined as ZEND_DEBUG at the top > of the file, which in turn is defined as 0 in php_config.h. > > So is it worth keeping such patches around if they apply to code > that's disabled? Or do we want them around to protect an innocent > soul who wants to venture out with custom compile options (in > this case --debug). > > martijn@ >
ah that one.. I was thinking of enabling ZEND_MM_HEAP_PROTECTION, it worked in the scripts I'd tested with, but it was too close to release to do it. Since it was removed in 7.0 it's a dead-end anyway, so ok to remove the patch.
