Hi all, Can't comment on the patch itself but, given that currently lpass package is unusable[0], it would be great if this went in sooner rather than later :^)
[0] https://github.com/lastpass/lastpass-cli/issues/409 Cheers, Raf On Wed, May 23, 2018 at 09:45:47AM BST, Björn Ketelaars wrote: > Enclosed a diff for bringing lastpass-cli to the latest version, which > is a maintenance release. Changelog can be found at > https://github.com/lastpass/lastpass-cli/blob/master/CHANGELOG.md > > make test failed sporadically, which is also the case for the version > in-tree. Root cause has been fixed and a diff has been sent upstream. > For now an additional patch is required. > > While here change MAINTAINER mail address. > > make test runs successfully. Tested on amd64. > > OK? > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/security/lastpass-cli/Makefile,v > retrieving revision 1.14 > diff -u -p -r1.14 Makefile > --- Makefile 16 Mar 2018 17:15:46 -0000 1.14 > +++ Makefile 23 May 2018 08:32:45 -0000 > @@ -2,14 +2,14 @@ > > COMMENT = LastPass command line interface tool > > -V = 1.3.0 > +V = 1.3.1 > DISTNAME = lastpass-cli-${V} > > CATEGORIES = security > > HOMEPAGE = https://github.com/lastpass/lastpass-cli > > -MAINTAINER = Bjorn Ketelaars <bjorn.ketela...@hydroxide.nl> > +MAINTAINER = Bjorn Ketelaars <b...@openbsd.org> > > # GPLv2 > PERMIT_PACKAGE_CDROM = Yes > Index: distinfo > =================================================================== > RCS file: /cvs/ports/security/lastpass-cli/distinfo,v > retrieving revision 1.12 > diff -u -p -r1.12 distinfo > --- distinfo 16 Mar 2018 17:15:46 -0000 1.12 > +++ distinfo 23 May 2018 08:32:45 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (lastpass-cli-1.3.0.tar.gz) = > u8/Wc9ZoKH53Pu9E2mX70vKS2qITo5Uo8xA3xSjbz+Q= > -SIZE (lastpass-cli-1.3.0.tar.gz) = 113969 > +SHA256 (lastpass-cli-1.3.1.tar.gz) = > JdyaDJmhDucLWzmR1SVEjCXzEsxp+gIW16xwxK44Sxs= > +SIZE (lastpass-cli-1.3.1.tar.gz) = 114843 > Index: patches/patch-config_c > =================================================================== > RCS file: patches/patch-config_c > diff -N patches/patch-config_c > --- /dev/null 1 Jan 1970 00:00:00 -0000 > +++ patches/patch-config_c 23 May 2018 08:32:45 -0000 > @@ -0,0 +1,16 @@ > +$OpenBSD$ > + > +Fix segfault. Taken from https://github.com/lastpass/lastpass-cli/pull/411 > + > +Index: config.c > +--- config.c.orig > ++++ config.c > +@@ -175,7 +175,7 @@ enum config_type config_path_type(const char *name) > + } > + > + /* lock files are runtime */ > +- if (strlen(name) >= 5 && !strcmp(name-5, ".lock")) { > ++ if (strlen(name) >= 5 && !strcmp(name + strlen(name) - 5, ".lock")) { > + return CONFIG_RUNTIME; > + } > + >
